Supervised User interstitial: Update strings to be more child-friendly

Supervised User interstitial: Update strings to be more child-friendly

BUG=649765
Committed: https://crrev.com/5bc991581addab505a76dfc293c140daff76b429
Cr-Commit-Position: refs/heads/master@{#431530}

[Marc Treib, 2016-11-08 16:29:34]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 16:29:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2016-11-08 16:33:44]

treib@chromium.org changed reviewers:
+ pam@chromium.org

[Marc Treib, 2016-11-08 16:33:44]

PTAL!

https://codereview.chromium.org/2479413004/diff/1/components/supervised_user_...
File
components/supervised_user_error_page/resources/supervised_user_block_interstitial.css
(right):

https://codereview.chromium.org/2479413004/diff/1/components/supervised_user_...
components/supervised_user_error_page/resources/supervised_user_block_interstitial.css:24:
margin-bottom: 20px;
This is totally made up :)  Probably Rachel should take a look. I'll make
screenshots.

https://codereview.chromium.org/2479413004/diff/1/components/supervised_user_...
File components/supervised_user_error_page/supervised_user_error_page.cc
(right):

https://codereview.chromium.org/2479413004/diff/1/components/supervised_user_...
components/supervised_user_error_page/supervised_user_error_page.cc:97: if
(is_child_account) {
SUs don't get the header, which will effectively hide the corresponding element.

https://codereview.chromium.org/2479413004/diff/1/components/supervised_user_...
File components/supervised_user_error_page_strings.grdp (left):

https://codereview.chromium.org/2479413004/diff/1/components/supervised_user_...
components/supervised_user_error_page_strings.grdp:25: <message
name="IDS_CHILD_BLOCK_INTERSTITIAL_REQUEST_ACCESS_BUTTON" desc="A button for
requesting access to blocked sites.">
Unused, and anyway identical to the one above.

https://codereview.chromium.org/2479413004/diff/1/components/supervised_user_...
File components/supervised_user_error_page_strings.grdp (right):

https://codereview.chromium.org/2479413004/diff/1/components/supervised_user_...
components/supervised_user_error_page_strings.grdp:5: Site blocked
Apparently we now use "site" instead of "page"; I've changed all the strings
here.

https://codereview.chromium.org/2479413004/diff/1/components/supervised_user_...
components/supervised_user_error_page_strings.grdp:32: You asked your parent if
it's OK to visit this site.
I think we decided at some point that capitalized "OK" is the way to go. It's
also consistent with other, now-removed strings above :D

[commit-bot: I haz the power, 2016-11-08 16:39:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 16:39:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Pam (message me for reviews), 2016-11-08 17:15:11]

LGTM, unless we want to keep 2-parent support. I'm OK either way; it's not hard
to put back.

https://codereview.chromium.org/2479413004/diff/1/components/supervised_user_...
File components/supervised_user_error_page/supervised_user_error_page.cc
(right):

https://codereview.chromium.org/2479413004/diff/1/components/supervised_user_...
components/supervised_user_error_page/supervised_user_error_page.cc:106:
l10n_util::GetStringUTF16(IDS_CHILD_BLOCK_INTERSTITIAL_MESSAGE);
Hmm, two-parent management will be coming eventually.

[Marc Treib, 2016-11-08 17:30:29]

https://codereview.chromium.org/2479413004/diff/1/components/supervised_user_...
File components/supervised_user_error_page/supervised_user_error_page.cc
(right):

https://codereview.chromium.org/2479413004/diff/1/components/supervised_user_...
components/supervised_user_error_page/supervised_user_error_page.cc:106:
l10n_util::GetStringUTF16(IDS_CHILD_BLOCK_INTERSTITIAL_MESSAGE);
On 2016/11/08 17:15:11, Pam (message me for reviews) wrote:
> Hmm, two-parent management will be coming eventually.

But the message doesn't reference the parent(s) anymore :)
(It's "Looks like you need permission to visit this site")

[Marc Treib, 2016-11-08 18:01:02]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 18:02:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2016-11-08 18:02:33]

https://codereview.chromium.org/2479413004/diff/20001/components/supervised_u...
File components/supervised_user_error_page_strings.grdp (right):

https://codereview.chromium.org/2479413004/diff/20001/components/supervised_u...
components/supervised_user_error_page_strings.grdp:38: We could not reach your
parent at the moment. Please try again.
If I understand the guidelines correctly, then these two-sentence strings should
keep the periods, but all of the others shouldn't. The inconsistency is
annoying, but if those are the rules...

[Pam (message me for reviews), 2016-11-08 18:09:29]

LGTM

[commit-bot: I haz the power, 2016-11-08 18:50:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 18:50:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Marc Treib, 2016-11-09 10:47:48]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 10:48:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 11:44:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 11:44:56]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-11-10 12:54:27]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 12:54:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 13:42:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 13:42:02]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-11-10 14:40:14]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 14:40:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 15:16:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 15:16:53]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-11-10 16:54:49]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 16:55:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Pam (message me for reviews), 2016-11-10 17:03:24]

Still LGTM, FWIW.

[commit-bot: I haz the power, 2016-11-10 17:29:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 17:29:11]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-11-11 09:03:38]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2016-11-11 09:03:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 09:08:00]

Committed patchset #6 (id:90001)

[commit-bot: I haz the power, 2016-11-11 09:10:33]

Description was changed from

==========
Supervised User interstitial: Update strings to be more child-friendly

BUG=649765
==========

to

==========
Supervised User interstitial: Update strings to be more child-friendly

BUG=649765

Committed: https://crrev.com/5bc991581addab505a76dfc293c140daff76b429
Cr-Commit-Position: refs/heads/master@{#431530}
==========

[commit-bot: I haz the power, 2016-11-11 09:10:34]

Patchset 6 (id:??) landed as
https://crrev.com/5bc991581addab505a76dfc293c140daff76b429
Cr-Commit-Position: refs/heads/master@{#431530}