Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2479403002: Move all ancestor-dependent properties out of PaintLayer and into an aux. struct. (Closed)

Created:
4 years, 1 month ago by chrishtr
Modified:
4 years, 1 month ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move all ancestor-dependent properties out of PaintLayer and into an aux. struct. This makes PaintLayer smaller, which improves performance of code, such as hit testing, that does not need to use these ancestor-dependent compositing properties. This patch makes hit testing on paint layers >= 15% faster. In particular, it makes the Events/hit-test-lots-of-layers.html performance test ~15% faster. It had recently regressed when I added an IntRect.) BUG=659059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/8af9d0bee7cdbd2db09562939b7d33696d9a7447 Cr-Commit-Position: refs/heads/master@{#430509}

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -69 lines) Patch
M third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp View 4 chunks +13 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 5 chunks +26 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 2 2 chunks +3 lines, -12 lines 1 comment Download

Messages

Total messages: 15 (10 generated)
chrishtr
The possible downside of this CL is that it increases the memory footprint of PaintLayer. ...
4 years, 1 month ago (2016-11-08 00:48:42 UTC) #5
Xianzhu
lgtm
4 years, 1 month ago (2016-11-08 03:44:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479403002/40001
4 years, 1 month ago (2016-11-08 03:44:50 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-08 03:48:47 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 03:55:21 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8af9d0bee7cdbd2db09562939b7d33696d9a7447
Cr-Commit-Position: refs/heads/master@{#430509}

Powered by Google App Engine
This is Rietveld 408576698