Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

Issue 2479403002: Move all ancestor-dependent properties out of PaintLayer and into an aux. struct. (Closed)
Patch Set: none Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
index b7d4b8c22446a55db390781615d6940e9e1368d0..1c567e638d648337bec4ec130acd580c7f999139 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
@@ -144,7 +144,6 @@ void CompositingInputsUpdater::updateRecursive(PaintLayer* layer,
if (updateType == ForceUpdate) {
PaintLayer::AncestorDependentCompositingInputs properties;
- PaintLayer::RareAncestorDependentCompositingInputs rareProperties;
if (!layer->isRootLayer()) {
if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
@@ -168,16 +167,16 @@ void CompositingInputsUpdater::updateRecursive(PaintLayer* layer,
}
const PaintLayer* parent = layer->parent();
- rareProperties.opacityAncestor =
+ properties.opacityAncestor =
parent->isTransparent() ? parent : parent->opacityAncestor();
- rareProperties.transformAncestor =
+ properties.transformAncestor =
parent->transform() ? parent : parent->transformAncestor();
- rareProperties.filterAncestor = parent->hasFilterInducingProperty()
- ? parent
- : parent->filterAncestor();
+ properties.filterAncestor = parent->hasFilterInducingProperty()
+ ? parent
+ : parent->filterAncestor();
bool layerIsFixedPosition =
layer->layoutObject()->style()->position() == FixedPosition;
- rareProperties.nearestFixedPositionLayer =
+ properties.nearestFixedPositionLayer =
layerIsFixedPosition ? layer : parent->nearestFixedPositionLayer();
if (info.hasAncestorWithClipRelatedProperty) {
@@ -198,7 +197,7 @@ void CompositingInputsUpdater::updateRecursive(PaintLayer* layer,
? properties.clippingContainer->enclosingLayer()
: layer->compositor()->rootLayer();
if (hasClippedStackingAncestor(layer, clippingLayer))
- rareProperties.clipParent = clippingLayer;
+ properties.clipParent = clippingLayer;
}
}
@@ -208,22 +207,21 @@ void CompositingInputsUpdater::updateRecursive(PaintLayer* layer,
const PaintLayer* parentLayerOnContainingBlockChain =
findParentLayerOnContainingBlockChain(containingBlock);
- rareProperties.ancestorScrollingLayer =
+ properties.ancestorScrollingLayer =
parentLayerOnContainingBlockChain->ancestorScrollingLayer();
if (parentLayerOnContainingBlockChain->scrollsOverflow())
- rareProperties.ancestorScrollingLayer =
- parentLayerOnContainingBlockChain;
+ properties.ancestorScrollingLayer = parentLayerOnContainingBlockChain;
if (layer->stackingNode()->isStacked() &&
- rareProperties.ancestorScrollingLayer &&
+ properties.ancestorScrollingLayer &&
!info.ancestorStackingContext->layoutObject()->isDescendantOf(
- rareProperties.ancestorScrollingLayer->layoutObject()))
- rareProperties.scrollParent = rareProperties.ancestorScrollingLayer;
+ properties.ancestorScrollingLayer->layoutObject()))
+ properties.scrollParent = properties.ancestorScrollingLayer;
}
}
layer->updateAncestorDependentCompositingInputs(
- properties, rareProperties, info.hasAncestorWithClipPath);
+ properties, info.hasAncestorWithClipPath);
}
if (layer->stackingNode()->isStackingContext())
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayer.h » ('j') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698