Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2479383004: Stop converting test contents for tests in imported/wpt. (Closed)

Created:
4 years, 1 month ago by qyearsley
Modified:
4 years, 1 month ago
Reviewers:
tkent, jsbell, foolip
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, darin-cc_chromium.org, dcheng, Dirk Pranke, jam, tfarina, jeffcarp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop converting test contents for tests in imported/wpt. Looking at http://crbug.com/654081, it looks like it should now be unnecessary except for some cases in csswg-test. Import wpt@2782308f4187e73043324272552cf1bd90edc784 Using update-w3c-deps in Chromium a0b55895c5825ff8c8d0c363357a1e45c374b814. BUG=654081 Committed: https://crrev.com/b44cdf9eb78d092d51f3ad10cef882025716c4be Cr-Commit-Position: refs/heads/master@{#430745}

Patch Set 1 #

Total comments: 1

Messages

Total messages: 10 (4 generated)
qyearsley
4 years, 1 month ago (2016-11-08 18:42:07 UTC) #2
foolip
LGTM, sweet! There are more changes than what I found, are those newly imported or ...
4 years, 1 month ago (2016-11-08 19:48:52 UTC) #3
jsbell
https://codereview.chromium.org/2479383004/diff/1/third_party/WebKit/LayoutTests/imported/wpt/html/editing/dnd/cross-document/002.html File third_party/WebKit/LayoutTests/imported/wpt/html/editing/dnd/cross-document/002.html (right): https://codereview.chromium.org/2479383004/diff/1/third_party/WebKit/LayoutTests/imported/wpt/html/editing/dnd/cross-document/002.html#newcode24 third_party/WebKit/LayoutTests/imported/wpt/html/editing/dnd/cross-document/002.html:24: <script>document.getElementsByTagName("iframe")[0].src = crossOriginUrl("www", "001-1.html"); Filed https://github.com/w3c/web-platform-tests/issues/4183 for this file ...
4 years, 1 month ago (2016-11-08 20:58:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479383004/1
4 years, 1 month ago (2016-11-08 22:05:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 23:06:18 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 23:21:36 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b44cdf9eb78d092d51f3ad10cef882025716c4be
Cr-Commit-Position: refs/heads/master@{#430745}

Powered by Google App Engine
This is Rietveld 408576698