Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py

Issue 2479383004: Stop converting test contents for tests in imported/wpt. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py
index 356b601f591ea20694d0c9729538ab978d7572aa..261a00505d7358d8764cac32a227d38423aaec4f 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py
@@ -39,9 +39,19 @@ _log = logging.getLogger(__name__)
def convert_for_webkit(new_path, filename, reference_support_info, host=Host()):
"""Converts a file's contents so the Blink layout test runner can run it.
+ Args:
+ new_path: Absolute path where file will be copied to in the Chromium repo.
+ filename: Absolute path to where the file is.
+ reference_support_info: Dict of information about a related reference HTML, if any.
+
Returns:
- A pair: the list of modified properties, and the modified text if the file was modified, None otherwise.
+ A pair of (list of modified CSS properties, modified text) if the file
+ should be modified; None, if the file is not modified.
"""
+ # Conversion is not necessary for any tests in wpt now; see http://crbug.com/654081.
+ if re.search(r'[/\\]imported[/\\]wpt[/\\]', new_path):
+ return None
+
contents = host.filesystem.read_binary_file(filename)
converter = _W3CTestConverter(new_path, filename, reference_support_info, host)
if filename.endswith('.css'):

Powered by Google App Engine
This is Rietveld 408576698