Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2479373006: [ic] Support Api getters by data handlers. (Closed)

Created:
4 years, 1 month ago by Igor Sheludko
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Support Api getters by data handlers. BUG=v8:5561 Committed: https://crrev.com/bdf04d99cd26f3e6fe2a23e07f127cef5c95d032 Cr-Commit-Position: refs/heads/master@{#40839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -11 lines) Patch
M src/code-stub-assembler.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M src/counters.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ic/handler-configuration.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/ic/handler-configuration-inl.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +24 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (14 generated)
Igor Sheludko
PTAL
4 years, 1 month ago (2016-11-08 08:56:04 UTC) #12
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-11-08 12:49:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479373006/20001
4 years, 1 month ago (2016-11-08 14:35:45 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-11-08 14:38:08 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:26:23 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdf04d99cd26f3e6fe2a23e07f127cef5c95d032
Cr-Commit-Position: refs/heads/master@{#40839}

Powered by Google App Engine
This is Rietveld 408576698