Use unique_ptr return from CPDF_Parser::ParseIndirectObject()

Use unique_ptr return from CPDF_Parser::ParseIndirectObject()

In turn, propgate to callers.  This introduces a few
release() calls that will go away as more code is converted.
It also removes a couple of WrapUnique calls that are no
longer needed as ownership of the object flows along.

Committed: https://pdfium.googlesource.com/pdfium/+/5ab31ef3ed4c86211f1ebb3686abb4f5a66472ec

[Tom Sepez, 2016-11-07 18:55:39]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 18:55:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 18:56:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 18:56:55]

Dry run: Try jobs failed on following builders:
  linux_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/build...)
  mac on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac/builds/2685)
  mac_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_no_v8/build...)

[Tom Sepez, 2016-11-07 18:58:44]

https://codereview.chromium.org/2479303002/diff/1/core/fpdfapi/parser/cpdf_da...
File core/fpdfapi/parser/cpdf_data_avail.cpp (right):

https://codereview.chromium.org/2479303002/diff/1/core/fpdfapi/parser/cpdf_da...
core/fpdfapi/parser/cpdf_data_avail.cpp:1403: if (!pPages)
note: probably can re-order this test and nest the one above it inside.

[Tom Sepez, 2016-11-07 20:13:10]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 20:13:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 20:18:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 20:18:48]

Dry run: Try jobs failed on following builders:
  android on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/android/builds/...)

[Tom Sepez, 2016-11-07 20:58:53]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 20:59:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-11-07 21:06:38]

Description was changed from

==========
Use unique_ptr return from CPDF_Parser::GetObject()

In turn, propgate to callers.  This introduces a few
release() calls that will go away as more code is converted.
==========

to

==========
Use unique_ptr return from CPDF_Parser::GetObject()

In turn, propgate to callers.  This introduces a few
release() calls that will go away as more code is converted.
==========

[Tom Sepez, 2016-11-07 21:06:39]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Tom Sepez, 2016-11-07 21:07:01]

Lei, ready for review.

[commit-bot: I haz the power, 2016-11-07 21:13:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 21:13:51]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-11-07 21:19:23]

Description was changed from

==========
Use unique_ptr return from CPDF_Parser::GetObject()

In turn, propgate to callers.  This introduces a few
release() calls that will go away as more code is converted.
==========

to

==========
Use unique_ptr return from CPDF_Parser::ParseIndirectObject()

In turn, propgate to callers.  This introduces a few
release() calls that will go away as more code is converted.
==========

[Tom Sepez, 2016-11-07 21:20:16]

Description was changed from

==========
Use unique_ptr return from CPDF_Parser::ParseIndirectObject()

In turn, propgate to callers.  This introduces a few
release() calls that will go away as more code is converted.
==========

to

==========
Use unique_ptr return from CPDF_Parser::ParseIndirectObject()

In turn, propgate to callers.  This introduces a few
release() calls that will go away as more code is converted.
It also removes a couple of WrapUnique calls that are no
longer needed as ownership of the object flows along.
==========

[Lei Zhang, 2016-11-07 21:42:35]

lgtm

https://codereview.chromium.org/2479303002/diff/60001/core/fpdfapi/parser/cpd...
File core/fpdfapi/parser/cpdf_parser.cpp (right):

https://codereview.chromium.org/2479303002/diff/60001/core/fpdfapi/parser/cpd...
core/fpdfapi/parser/cpdf_parser.cpp:827: pObj.release();
Maybe: m_pTrailer = ToDictionary(pObj.release()));

and fix up |m_pTrailer| later?

[Tom Sepez, 2016-11-07 21:48:38]

https://codereview.chromium.org/2479303002/diff/60001/core/fpdfapi/parser/cpd...
File core/fpdfapi/parser/cpdf_parser.cpp (right):

https://codereview.chromium.org/2479303002/diff/60001/core/fpdfapi/parser/cpd...
core/fpdfapi/parser/cpdf_parser.cpp:827: pObj.release();
On 2016/11/07 21:42:35, Lei Zhang wrote:
> Maybe: m_pTrailer = ToDictionary(pObj.release()));
> 
> and fix up |m_pTrailer| later?

I think it becomes a std::move at some point once m_pTrailer changed.

[Tom Sepez, 2016-11-07 21:48:46]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-11-07 21:48:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 21:49:22]

Description was changed from

==========
Use unique_ptr return from CPDF_Parser::ParseIndirectObject()

In turn, propgate to callers.  This introduces a few
release() calls that will go away as more code is converted.
It also removes a couple of WrapUnique calls that are no
longer needed as ownership of the object flows along.
==========

to

==========
Use unique_ptr return from CPDF_Parser::ParseIndirectObject()

In turn, propgate to callers.  This introduces a few
release() calls that will go away as more code is converted.
It also removes a couple of WrapUnique calls that are no
longer needed as ownership of the object flows along.

Committed:
https://pdfium.googlesource.com/pdfium/+/5ab31ef3ed4c86211f1ebb3686abb4f5a664...
==========

[commit-bot: I haz the power, 2016-11-07 21:49:23]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/5ab31ef3ed4c86211f1ebb3686abb4f5a664...