core/fpdfapi/parser/cpdf_indirect_object_holder.h - Issue 2479303002: Use unique_ptr return from CPDF_Parser::ParseIndirectObject()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/parser/cpdf_indirect_object_holder.h

Issue 2479303002: Use unique_ptr return from CPDF_Parser::ParseIndirectObject() (Closed)

Patch Set: Work around android Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/parser/cpdf_indirect_object_holder.h

diff --git a/core/fpdfapi/parser/cpdf_indirect_object_holder.h b/core/fpdfapi/parser/cpdf_indirect_object_holder.h

index fcd77215ebd07ccdb7ba13e8828001f5a56407a1..db6f4acbf40eddbb9dd9e19d0a37a02210c8e4a6 100644

--- a/core/fpdfapi/parser/cpdf_indirect_object_holder.h

+++ b/core/fpdfapi/parser/cpdf_indirect_object_holder.h

@@ -39,7 +39,7 @@ class CPDF_IndirectObjectHolder {

const_iterator end() const { return m_IndirectObjs.end(); }

protected:

- virtual CPDF_Object* ParseIndirectObject(uint32_t objnum);

+ virtual std::unique_ptr<CPDF_Object> ParseIndirectObject(uint32_t objnum);

private:

uint32_t m_LastObjNum;