Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2479173002: There should never be unplaced floats from other blocks. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
rhogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

There should never be unplaced floats from other blocks. When positioning new floats in a block, all unplaced floats should belong to said block. If we find unplaced floats from other blocks, someone somewhere must have forgotten to place them on their own. No need for code to skip such floats. DCHECK instead. Committed: https://crrev.com/563262aad0bd91fe3bc2b644e94cdf3eb5d24807 Cr-Commit-Position: refs/heads/master@{#430544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
I just can't think of any legitimate scenario where we could find unplaced floats that ...
4 years, 1 month ago (2016-11-07 14:29:31 UTC) #4
eae
LGTM
4 years, 1 month ago (2016-11-08 01:03:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479173002/1
4 years, 1 month ago (2016-11-08 07:51:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 07:58:00 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 08:05:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/563262aad0bd91fe3bc2b644e94cdf3eb5d24807
Cr-Commit-Position: refs/heads/master@{#430544}

Powered by Google App Engine
This is Rietveld 408576698