Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

Issue 2479173002: There should never be unplaced floats from other blocks. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
index c3510f973e22afc515e8188f6e701bb74f3f47fb..fedd19162228abdcff5f0adad7366de1af0044ae 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
@@ -3632,10 +3632,8 @@ bool LayoutBlockFlow::positionNewFloats(LineWidth* width) {
for (; it != end; ++it) {
FloatingObject& floatingObject = *it->get();
// The containing block is responsible for positioning floats, so if we have
- // floats in our list that come from somewhere else, do not attempt to
- // position them.
- if (floatingObject.layoutObject()->containingBlock() != this)
- continue;
+ // unplaced floats in our list that come from somewhere else, we have a bug.
+ DCHECK_EQ(floatingObject.layoutObject()->containingBlock(), this);
LayoutBox* childBox = floatingObject.layoutObject();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698