Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2479023003: Remove is_fling flag for fling intervention (Closed)

Created:
4 years, 1 month ago by lanwei
Modified:
4 years, 1 month ago
CC:
chromium-reviews, eae+blinkwatch, nyquist+watch-blimp_chromium.org, dglazkov+blink, kmarshall+watch-blimp_chromium.org, kinuko+watch, shaktisahu+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, jam, gcasto+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, darin-cc_chromium.org, lethalantidote+watch-blimp_chromium.org, blink-reviews, scf+watch-blimp_chromium.org, mlamouri+watch-content_chromium.org, tdresser+watch_chromium.org, dtapuska+blinkwatch_chromium.org, khushalsagar+watch-blimp_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, dtapuska+chromiumwatch_chromium.org, blink-reviews-api_chromium.org, blink-reviews-events_chromium.org, dtrainor+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In the previous patch, https://codereview.chromium.org/1923973002/, we added a is_fling flag to indicate if the active fling is happening on either main or impl thread. Now we only consider about scrolling happening in impl thread and we will use ack states to indicate if we want to make the touch events uncancelable. BUG=595327 Committed: https://crrev.com/8f1957b19f5c0e8e09dc98480c613e2e5c59cd99 Cr-Commit-Position: refs/heads/master@{#430640}

Patch Set 1 : remove flag #

Total comments: 1

Patch Set 2 : Rename ack state #

Total comments: 4

Patch Set 3 : Make enum explicitly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -125 lines) Patch
M blimp/client/core/input/blimp_input_handler_wrapper.h View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/client/core/input/blimp_input_handler_wrapper.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/input/input_event_ack_state.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/input/input_event_filter.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/input/input_event_filter.cc View 1 2 3 chunks +1 line, -14 lines 0 comments Download
M content/renderer/input/input_handler_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/input/input_handler_manager.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/input/input_handler_manager_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/input/input_handler_wrapper.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/input/input_handler_wrapper.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M content/renderer/input/main_thread_event_queue.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/input/main_thread_event_queue.cc View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M content/renderer/input/main_thread_event_queue_unittest.cc View 1 2 chunks +51 lines, -69 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_widget_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PlatformTouchEvent.h View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebInputEvent.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/events/blink/input_handler_proxy.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 1 2 3 chunks +7 lines, -2 lines 0 comments Download
M ui/events/blink/input_handler_proxy_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 43 (27 generated)
lanwei
4 years, 1 month ago (2016-11-06 22:52:52 UTC) #11
lanwei
4 years, 1 month ago (2016-11-07 02:00:30 UTC) #15
tdresser
https://codereview.chromium.org/2479023003/diff/20001/content/common/input/input_event_ack_state.h File content/common/input/input_event_ack_state.h (right): https://codereview.chromium.org/2479023003/diff/20001/content/common/input/input_event_ack_state.h#newcode15 content/common/input/input_event_ack_state.h:15: INPUT_EVENT_ACK_STATE_NOT_CONSUMED_NON_BLOCKING, Should this be NOT_CONSUMED_SET_NON_BLOCKING? Could we just use ...
4 years, 1 month ago (2016-11-07 17:57:31 UTC) #17
lanwei
4 years, 1 month ago (2016-11-07 21:38:23 UTC) #20
tdresser
LGTM. https://codereview.chromium.org/2479023003/diff/40001/content/renderer/input/input_event_filter.cc File content/renderer/input/input_event_filter.cc (right): https://codereview.chromium.org/2479023003/diff/40001/content/renderer/input/input_event_filter.cc#newcode241 content/renderer/input/input_event_filter.cc:241: ack_state == INPUT_EVENT_ACK_STATE_SET_NON_BLOCKING_DUE_TO_FLING) { Nit: might be nice ...
4 years, 1 month ago (2016-11-07 21:58:49 UTC) #21
lanwei
wez@chromium.org: Please review changes in blimp/ avi@chromium.org: Please review changes in content/renderer/ tkent@chromium.org: Please review ...
4 years, 1 month ago (2016-11-07 22:08:29 UTC) #23
Wez
https://codereview.chromium.org/2479023003/diff/40001/blimp/client/core/input/blimp_input_handler_wrapper.cc File blimp/client/core/input/blimp_input_handler_wrapper.cc (right): https://codereview.chromium.org/2479023003/diff/40001/blimp/client/core/input/blimp_input_handler_wrapper.cc#newcode74 blimp/client/core/input/blimp_input_handler_wrapper.cc:74: default: This should explicitly catch the new enum, rather ...
4 years, 1 month ago (2016-11-07 22:54:07 UTC) #24
lanwei
https://codereview.chromium.org/2479023003/diff/40001/blimp/client/core/input/blimp_input_handler_wrapper.cc File blimp/client/core/input/blimp_input_handler_wrapper.cc (right): https://codereview.chromium.org/2479023003/diff/40001/blimp/client/core/input/blimp_input_handler_wrapper.cc#newcode74 blimp/client/core/input/blimp_input_handler_wrapper.cc:74: default: On 2016/11/07 22:54:07, Wez wrote: > This should ...
4 years, 1 month ago (2016-11-07 23:25:18 UTC) #27
lanwei
4 years, 1 month ago (2016-11-07 23:25:55 UTC) #28
Wez
Perfect - thanks. :) LGTM
4 years, 1 month ago (2016-11-07 23:34:33 UTC) #29
tkent
> tkent@chromium.org: Please review changes in > third_party/WebKit/ lgtm
4 years, 1 month ago (2016-11-08 01:32:46 UTC) #32
Avi (use Gerrit)
content lgtm
4 years, 1 month ago (2016-11-08 16:23:49 UTC) #35
dtapuska
On 2016/11/08 16:23:49, Avi wrote: > content lgtm lgtm
4 years, 1 month ago (2016-11-08 17:01:21 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479023003/60001
4 years, 1 month ago (2016-11-08 17:03:59 UTC) #39
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 1 month ago (2016-11-08 17:09:59 UTC) #41
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 17:16:26 UTC) #43
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8f1957b19f5c0e8e09dc98480c613e2e5c59cd99
Cr-Commit-Position: refs/heads/master@{#430640}

Powered by Google App Engine
This is Rietveld 408576698