Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1923973002: Add UMA metric for tracking listeners for blocking touch while fling is happening (Closed)

Created:
4 years, 7 months ago by lanwei
Modified:
4 years, 7 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org, jam, Rick Byers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA metric for tracking listeners for blocking touch while fling is happening. In the touch scrolling intervention proposal, alexclarke@ proposed that we could treat all touchstart event listeners as passive while there’s an active fling animation. We are adding a metric that records when touchstarts are successfully preventDefaulted() during fling to measure breakage of event handlers. BUG=607245 Committed: https://crrev.com/8f486d67c25c4c856ea02ecf0edc02757884bd46 Cr-Commit-Position: refs/heads/master@{#394179}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add fling flag to WebTouchEvent #

Total comments: 4

Patch Set 3 : Add fling bit in both CC and renderer and Fix unittests #

Patch Set 4 : Refactor and rename #

Total comments: 3

Patch Set 5 : Sync the fling states #

Total comments: 10

Patch Set 6 : Sync fling states in main thread event queue #

Total comments: 6

Patch Set 7 : #

Total comments: 3

Patch Set 8 : Change comments in histogram #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -1 line) Patch
M blimp/client/feature/compositor/blimp_input_handler_wrapper.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M blimp/client/feature/compositor/blimp_input_handler_wrapper.cc View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/android/synchronous_compositor_filter.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/android/synchronous_compositor_filter.cc View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/input/input_event_filter.h View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/input/input_event_filter.cc View 1 2 3 4 5 6 2 chunks +14 lines, -0 lines 0 comments Download
M content/renderer/input/input_handler_manager.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/input/input_handler_manager.cc View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/input/input_handler_manager_client.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/input/input_handler_wrapper.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/input/input_handler_wrapper.cc View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/input/main_thread_event_queue.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/input/main_thread_event_queue.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/mus/compositor_mus_connection_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/TouchEventManager.cpp View 1 2 3 4 5 6 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/PlatformTouchEvent.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.cpp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebInputEvent.h View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 6 7 1 chunk +18 lines, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy_client.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 67 (34 generated)
lanwei
4 years, 7 months ago (2016-04-27 18:49:32 UTC) #4
lanwei
https://codereview.chromium.org/1923973002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1923973002/diff/1/tools/metrics/histograms/histograms.xml#newcode62550 tools/metrics/histograms/histograms.xml:62550: +<enum name="BooleanHandledTouchesOnPageload" type="int"> I will rename this one to ...
4 years, 7 months ago (2016-04-27 19:01:57 UTC) #5
dtapuska
https://codereview.chromium.org/1923973002/diff/1/content/browser/renderer_host/input/gesture_event_queue.h File content/browser/renderer_host/input/gesture_event_queue.h (right): https://codereview.chromium.org/1923973002/diff/1/content/browser/renderer_host/input/gesture_event_queue.h#newcode116 content/browser/renderer_host/input/gesture_event_queue.h:116: bool FlingInProgress() { return fling_in_progress_; } const https://codereview.chromium.org/1923973002/diff/1/content/browser/renderer_host/input/input_router_impl.cc File ...
4 years, 7 months ago (2016-04-27 19:05:13 UTC) #6
lanwei
Can you please take a look, and I am writing a test for fling flag?
4 years, 7 months ago (2016-04-28 18:54:28 UTC) #8
dtapuska
https://codereview.chromium.org/1923973002/diff/40001/third_party/WebKit/public/web/WebInputEvent.h File third_party/WebKit/public/web/WebInputEvent.h (right): https://codereview.chromium.org/1923973002/diff/40001/third_party/WebKit/public/web/WebInputEvent.h#newcode639 third_party/WebKit/public/web/WebInputEvent.h:639: bool isFlingInProgress; move this beside the other boolean and ...
4 years, 7 months ago (2016-04-28 18:59:09 UTC) #9
tdresser
https://codereview.chromium.org/1923973002/diff/40001/content/browser/renderer_host/input/touch_event_queue.h File content/browser/renderer_host/input/touch_event_queue.h (right): https://codereview.chromium.org/1923973002/diff/40001/content/browser/renderer_host/input/touch_event_queue.h#newcode245 content/browser/renderer_host/input/touch_event_queue.h:245: // True if a GestureFlingStart happens and false after ...
4 years, 7 months ago (2016-04-28 19:02:41 UTC) #10
lanwei
https://codereview.chromium.org/1923973002/diff/40001/content/browser/renderer_host/input/touch_event_queue.h File content/browser/renderer_host/input/touch_event_queue.h (right): https://codereview.chromium.org/1923973002/diff/40001/content/browser/renderer_host/input/touch_event_queue.h#newcode245 content/browser/renderer_host/input/touch_event_queue.h:245: // True if a GestureFlingStart happens and false after ...
4 years, 7 months ago (2016-04-28 20:25:18 UTC) #11
lanwei
4 years, 7 months ago (2016-05-04 00:04:19 UTC) #14
lanwei
4 years, 7 months ago (2016-05-05 17:17:35 UTC) #15
dtapuska
https://codereview.chromium.org/1923973002/diff/120001/content/renderer/input/input_handler_manager.cc File content/renderer/input/input_handler_manager.cc (right): https://codereview.chromium.org/1923973002/diff/120001/content/renderer/input/input_handler_manager.cc#newcode224 content/renderer/input/input_handler_manager.cc:224: if (blink::WebInputEvent::isTouchEventType(input_event->type)) { this seems odd to repeatedly set ...
4 years, 7 months ago (2016-05-05 20:22:21 UTC) #16
tdresser
https://codereview.chromium.org/1923973002/diff/120001/third_party/WebKit/public/web/WebInputEvent.h File third_party/WebKit/public/web/WebInputEvent.h (right): https://codereview.chromium.org/1923973002/diff/120001/third_party/WebKit/public/web/WebInputEvent.h#newcode637 third_party/WebKit/public/web/WebInputEvent.h:637: bool shouldForceBePassive; On 2016/05/05 20:22:21, dtapuska wrote: > Combining ...
4 years, 7 months ago (2016-05-06 19:01:31 UTC) #17
lanwei
4 years, 7 months ago (2016-05-09 18:26:41 UTC) #20
tdresser
I'm not sure syncing the full state is the correct path forward here - wouldn't ...
4 years, 7 months ago (2016-05-09 19:31:09 UTC) #21
tdresser
On 2016/05/09 19:31:09, tdresser wrote: > I'm not sure syncing the full state is the ...
4 years, 7 months ago (2016-05-09 19:41:08 UTC) #22
tdresser
Do we need to distinguish between main and impl thread fling here? We might be ...
4 years, 7 months ago (2016-05-09 19:48:46 UTC) #23
lanwei
https://codereview.chromium.org/1923973002/diff/180001/blimp/client/feature/compositor/blimp_input_handler_wrapper.h File blimp/client/feature/compositor/blimp_input_handler_wrapper.h (right): https://codereview.chromium.org/1923973002/diff/180001/blimp/client/feature/compositor/blimp_input_handler_wrapper.h#newcode52 blimp/client/feature/compositor/blimp_input_handler_wrapper.h:52: void DidStartFlinging(bool is_on_impl) override; On 2016/05/09 19:48:45, tdresser wrote: ...
4 years, 7 months ago (2016-05-12 11:50:37 UTC) #25
tdresser
LGTM! https://codereview.chromium.org/1923973002/diff/240001/content/renderer/input/input_event_filter.h File content/renderer/input/input_event_filter.h (right): https://codereview.chromium.org/1923973002/diff/240001/content/renderer/input/input_event_filter.h#newcode91 content/renderer/input/input_event_filter.h:91: void SetIsFlingInMainThreadEventQueue(int routing_id, bool is_flinging); SetIsFlingingInMainThreadEventQueue or SetCurrentlyFlingingInMainThreadEventQueue. ...
4 years, 7 months ago (2016-05-13 13:42:21 UTC) #27
lanwei
https://codereview.chromium.org/1923973002/diff/240001/content/renderer/input/input_event_filter.h File content/renderer/input/input_event_filter.h (right): https://codereview.chromium.org/1923973002/diff/240001/content/renderer/input/input_event_filter.h#newcode91 content/renderer/input/input_event_filter.h:91: void SetIsFlingInMainThreadEventQueue(int routing_id, bool is_flinging); On 2016/05/13 13:42:21, tdresser ...
4 years, 7 months ago (2016-05-13 18:15:49 UTC) #30
lanwei
4 years, 7 months ago (2016-05-13 21:03:15 UTC) #39
dtapuska
On 2016/05/13 21:03:15, lanwei wrote: lgtm
4 years, 7 months ago (2016-05-16 13:56:28 UTC) #40
lanwei
sky@chromium.org: Please review changes in third_party/Webkit/* sievers@chromium.org: Please review changes in content/* nyquist@chromium.org: Please review ...
4 years, 7 months ago (2016-05-16 21:02:42 UTC) #44
sky
On 2016/05/16 21:02:42, lanwei wrote: > mailto:sky@chromium.org: Please review changes in > third_party/Webkit/* > > ...
4 years, 7 months ago (2016-05-16 21:29:08 UTC) #45
lanwei
tkent@chromium.org: Please review changes in third_party/Webkit/* Thank you very much!
4 years, 7 months ago (2016-05-16 22:54:04 UTC) #51
tkent
third_party/WebKit lgtm
4 years, 7 months ago (2016-05-16 23:07:38 UTC) #52
Ilya Sherman
https://codereview.chromium.org/1923973002/diff/320001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1923973002/diff/320001/tools/metrics/histograms/histograms.xml#newcode12406 tools/metrics/histograms/histograms.xml:12406: + the first touchmove events. Only recorded after the ...
4 years, 7 months ago (2016-05-17 01:21:46 UTC) #53
lanwei
https://codereview.chromium.org/1923973002/diff/320001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1923973002/diff/320001/tools/metrics/histograms/histograms.xml#newcode12406 tools/metrics/histograms/histograms.xml:12406: + the first touchmove events. Only recorded after the ...
4 years, 7 months ago (2016-05-17 02:11:08 UTC) #54
Ilya Sherman
histograms lgtm, thanks
4 years, 7 months ago (2016-05-17 03:51:09 UTC) #55
lanwei
4 years, 7 months ago (2016-05-17 17:46:07 UTC) #58
haibinlu
lgtm lgtm for blimp/client
4 years, 7 months ago (2016-05-17 17:48:12 UTC) #59
no sievers
content lgtm
4 years, 7 months ago (2016-05-17 18:45:33 UTC) #60
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923973002/340001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923973002/340001
4 years, 7 months ago (2016-05-17 18:49:47 UTC) #63
commit-bot: I haz the power
Committed patchset #8 (id:340001)
4 years, 7 months ago (2016-05-17 18:56:51 UTC) #65
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 19:03:02 UTC) #67
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/8f486d67c25c4c856ea02ecf0edc02757884bd46
Cr-Commit-Position: refs/heads/master@{#394179}

Powered by Google App Engine
This is Rietveld 408576698