Fix libc++ dependency for linux installer

Fix libc++ dependency for linux installer

Without this dependency, "gn gen" complains that libc++ isn't generated by any dependencies of the targets when building an ASAN build with is_chrome_branded=true on Linux.

Here are the gn args I used:

is_chrome_branded = true
is_asan = true
is_component_build = false
is_debug = false
is_lsan = true
symbol_level = 1

Here are the errors:

Generating files...
ERROR Input to targets not generated by a dependency.
The file:
  //out/GN_Asan/lib/libc++.so
is listed as an input or source for the targets:
  //chrome/installer/linux:stable_deb
  //chrome/installer/linux:stable_rpm
  //chrome/installer/linux:beta_deb
  //chrome/installer/linux:beta_rpm
  //chrome/installer/linux:unstable_deb
  //chrome/installer/linux:unstable_rpm
  //chrome/installer/linux:trunk_deb
  //chrome/installer/linux:trunk_rpm
  //chrome/installer/linux:asan_deb
  //chrome/installer/linux:asan_rpm
but no targets in the build generate that file.

Committed: https://crrev.com/7e98c2b4a1ec78272cb23b318b069bfe6a66871d
Cr-Commit-Position: refs/heads/master@{#431137}

[xhwang, 2016-11-05 06:44:04]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-05 06:44:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2016-11-05 07:25:03]

xhwang@chromium.org changed reviewers:
+ mmoss@chromium.org

[xhwang, 2016-11-05 07:25:04]

I am not familiar with this code so I have no idea what I am doing. I just made
sure "gn gen" works and it compiles.

PTAL

[commit-bot: I haz the power, 2016-11-05 07:57:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-05 07:57:50]

Dry run: This issue passed the CQ dry run.

[Michael Moss, 2016-11-08 15:18:41]

On 2016/11/05 07:25:04, xhwang_OOO_11_07 wrote:
> I am not familiar with this code so I have no idea what I am doing. I just
made
> sure "gn gen" works and it compiles.
> 
> PTAL

I'm also not familiar with this code, so I'm not sure if this is the right fix,
but I'm also not sure about the failure it's supposed to be trying to fix. If
this is really a problem, why aren't we seeing it everywhere, like on the bots
and stuff?

[xhwang, 2016-11-08 17:26:19]

Description was changed from

==========
Fix libc++ dependency for linux installer

Without this dependency, "gn gen" complains that libc++ isn't generated
by any dependencies of the targets.
==========

to

==========
Fix libc++ dependency for linux installer

Without this dependency, "gn gen" complains that libc++ isn't generated
by any dependencies of the targets when building an ASAN build with
is_chrome_branded=true on Linux.

Here are the gn args I used:

is_chrome_branded = true
is_asan = true
is_component_build = false
is_debug = false
is_lsan = true
symbol_level = 1

Here are the errors:

Generating files...
ERROR Input to targets not generated by a dependency.
The file:
  //out/GN_Asan/lib/libc++.so
is listed as an input or source for the targets:
  //chrome/installer/linux:stable_deb
  //chrome/installer/linux:stable_rpm
  //chrome/installer/linux:beta_deb
  //chrome/installer/linux:beta_rpm
  //chrome/installer/linux:unstable_deb
  //chrome/installer/linux:unstable_rpm
  //chrome/installer/linux:trunk_deb
  //chrome/installer/linux:trunk_rpm
  //chrome/installer/linux:asan_deb
  //chrome/installer/linux:asan_rpm
but no targets in the build generate that file.
==========

[xhwang, 2016-11-08 17:26:20]

xhwang@chromium.org changed reviewers:
+ glider@chromium.org

[xhwang, 2016-11-08 17:26:31]

Description was changed from

==========
Fix libc++ dependency for linux installer

Without this dependency, "gn gen" complains that libc++ isn't generated
by any dependencies of the targets when building an ASAN build with
is_chrome_branded=true on Linux.

Here are the gn args I used:

is_chrome_branded = true
is_asan = true
is_component_build = false
is_debug = false
is_lsan = true
symbol_level = 1

Here are the errors:

Generating files...
ERROR Input to targets not generated by a dependency.
The file:
  //out/GN_Asan/lib/libc++.so
is listed as an input or source for the targets:
  //chrome/installer/linux:stable_deb
  //chrome/installer/linux:stable_rpm
  //chrome/installer/linux:beta_deb
  //chrome/installer/linux:beta_rpm
  //chrome/installer/linux:unstable_deb
  //chrome/installer/linux:unstable_rpm
  //chrome/installer/linux:trunk_deb
  //chrome/installer/linux:trunk_rpm
  //chrome/installer/linux:asan_deb
  //chrome/installer/linux:asan_rpm
but no targets in the build generate that file.
==========

to

==========
Fix libc++ dependency for linux installer

Without this dependency, "gn gen" complains that libc++ isn't generated by any
dependencies of the targets when building an ASAN build with
is_chrome_branded=true on Linux.

Here are the gn args I used:

is_chrome_branded = true
is_asan = true
is_component_build = false
is_debug = false
is_lsan = true
symbol_level = 1

Here are the errors:

Generating files...
ERROR Input to targets not generated by a dependency.
The file:
  //out/GN_Asan/lib/libc++.so
is listed as an input or source for the targets:
  //chrome/installer/linux:stable_deb
  //chrome/installer/linux:stable_rpm
  //chrome/installer/linux:beta_deb
  //chrome/installer/linux:beta_rpm
  //chrome/installer/linux:unstable_deb
  //chrome/installer/linux:unstable_rpm
  //chrome/installer/linux:trunk_deb
  //chrome/installer/linux:trunk_rpm
  //chrome/installer/linux:asan_deb
  //chrome/installer/linux:asan_rpm
but no targets in the build generate that file.
==========

[xhwang, 2016-11-08 17:27:50]

+glider PTAL since mmoss isn't familiar with this code either.

mmoss: Sorry for the lack of details. I updated the CL description with exactly
what the error is.

[xhwang, 2016-11-09 21:16:51]

xhwang@chromium.org changed reviewers:
+ thestig@chromium.org

[xhwang, 2016-11-09 21:16:51]

It seems glider@ is OOO.

thestig: Could you please take a look at this CL? Or let me know who would be a
better reviewer. Thanks!

[Michael Moss, 2016-11-09 21:30:29]

On 2016/11/09 21:16:51, xhwang wrote:
> It seems glider@ is OOO.
> 
> thestig: Could you please take a look at this CL? Or let me know who would be
a
> better reviewer. Thanks!

dpranke might be able to say if this is "the right way" to do it, from a GN
perspective.

[Michael Moss, 2016-11-09 21:30:32]

On 2016/11/09 21:16:51, xhwang wrote:
> It seems glider@ is OOO.
> 
> thestig: Could you please take a look at this CL? Or let me know who would be
a
> better reviewer. Thanks!

dpranke might be able to say if this is "the right way" to do it, from a GN
perspective.

[xhwang, 2016-11-09 21:35:48]

xhwang@chromium.org changed reviewers:
+ dpranke@chromium.org

[xhwang, 2016-11-09 21:36:52]

Thanks!

dpranke: Could you PTAL?

Sorry for having so many reviewers added. Feel free to remove yourself from the
reviewer list!

[Dirk Pranke, 2016-11-10 00:17:29]

Yup, this looks right. LGTM.

[xhwang, 2016-11-10 00:22:54]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2016-11-10 00:23:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 00:33:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 00:33:07]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xhwang, 2016-11-10 00:35:07]

mmoss: Can I get your OWNERS stamp?

[Lei Zhang, 2016-11-10 00:42:56]

rs lgtm

[xhwang, 2016-11-10 00:43:55]

Thank you all for the review!

[xhwang, 2016-11-10 00:44:01]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2016-11-10 00:44:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 01:55:06]

Description was changed from

==========
Fix libc++ dependency for linux installer

Without this dependency, "gn gen" complains that libc++ isn't generated by any
dependencies of the targets when building an ASAN build with
is_chrome_branded=true on Linux.

Here are the gn args I used:

is_chrome_branded = true
is_asan = true
is_component_build = false
is_debug = false
is_lsan = true
symbol_level = 1

Here are the errors:

Generating files...
ERROR Input to targets not generated by a dependency.
The file:
  //out/GN_Asan/lib/libc++.so
is listed as an input or source for the targets:
  //chrome/installer/linux:stable_deb
  //chrome/installer/linux:stable_rpm
  //chrome/installer/linux:beta_deb
  //chrome/installer/linux:beta_rpm
  //chrome/installer/linux:unstable_deb
  //chrome/installer/linux:unstable_rpm
  //chrome/installer/linux:trunk_deb
  //chrome/installer/linux:trunk_rpm
  //chrome/installer/linux:asan_deb
  //chrome/installer/linux:asan_rpm
but no targets in the build generate that file.
==========

to

==========
Fix libc++ dependency for linux installer

Without this dependency, "gn gen" complains that libc++ isn't generated by any
dependencies of the targets when building an ASAN build with
is_chrome_branded=true on Linux.

Here are the gn args I used:

is_chrome_branded = true
is_asan = true
is_component_build = false
is_debug = false
is_lsan = true
symbol_level = 1

Here are the errors:

Generating files...
ERROR Input to targets not generated by a dependency.
The file:
  //out/GN_Asan/lib/libc++.so
is listed as an input or source for the targets:
  //chrome/installer/linux:stable_deb
  //chrome/installer/linux:stable_rpm
  //chrome/installer/linux:beta_deb
  //chrome/installer/linux:beta_rpm
  //chrome/installer/linux:unstable_deb
  //chrome/installer/linux:unstable_rpm
  //chrome/installer/linux:trunk_deb
  //chrome/installer/linux:trunk_rpm
  //chrome/installer/linux:asan_deb
  //chrome/installer/linux:asan_rpm
but no targets in the build generate that file.
==========

[commit-bot: I haz the power, 2016-11-10 01:55:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-10 01:57:56]

Description was changed from

==========
Fix libc++ dependency for linux installer

Without this dependency, "gn gen" complains that libc++ isn't generated by any
dependencies of the targets when building an ASAN build with
is_chrome_branded=true on Linux.

Here are the gn args I used:

is_chrome_branded = true
is_asan = true
is_component_build = false
is_debug = false
is_lsan = true
symbol_level = 1

Here are the errors:

Generating files...
ERROR Input to targets not generated by a dependency.
The file:
  //out/GN_Asan/lib/libc++.so
is listed as an input or source for the targets:
  //chrome/installer/linux:stable_deb
  //chrome/installer/linux:stable_rpm
  //chrome/installer/linux:beta_deb
  //chrome/installer/linux:beta_rpm
  //chrome/installer/linux:unstable_deb
  //chrome/installer/linux:unstable_rpm
  //chrome/installer/linux:trunk_deb
  //chrome/installer/linux:trunk_rpm
  //chrome/installer/linux:asan_deb
  //chrome/installer/linux:asan_rpm
but no targets in the build generate that file.
==========

to

==========
Fix libc++ dependency for linux installer

Without this dependency, "gn gen" complains that libc++ isn't generated by any
dependencies of the targets when building an ASAN build with
is_chrome_branded=true on Linux.

Here are the gn args I used:

is_chrome_branded = true
is_asan = true
is_component_build = false
is_debug = false
is_lsan = true
symbol_level = 1

Here are the errors:

Generating files...
ERROR Input to targets not generated by a dependency.
The file:
  //out/GN_Asan/lib/libc++.so
is listed as an input or source for the targets:
  //chrome/installer/linux:stable_deb
  //chrome/installer/linux:stable_rpm
  //chrome/installer/linux:beta_deb
  //chrome/installer/linux:beta_rpm
  //chrome/installer/linux:unstable_deb
  //chrome/installer/linux:unstable_rpm
  //chrome/installer/linux:trunk_deb
  //chrome/installer/linux:trunk_rpm
  //chrome/installer/linux:asan_deb
  //chrome/installer/linux:asan_rpm
but no targets in the build generate that file.

Committed: https://crrev.com/7e98c2b4a1ec78272cb23b318b069bfe6a66871d
Cr-Commit-Position: refs/heads/master@{#431137}
==========

[commit-bot: I haz the power, 2016-11-10 01:57:57]

Patchset 1 (id:??) landed as
https://crrev.com/7e98c2b4a1ec78272cb23b318b069bfe6a66871d
Cr-Commit-Position: refs/heads/master@{#431137}