Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2478973002: Fix libc++ dependency for linux installer (Closed)

Created:
4 years, 1 month ago by xhwang
Modified:
4 years, 1 month ago
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix libc++ dependency for linux installer Without this dependency, "gn gen" complains that libc++ isn't generated by any dependencies of the targets when building an ASAN build with is_chrome_branded=true on Linux. Here are the gn args I used: is_chrome_branded = true is_asan = true is_component_build = false is_debug = false is_lsan = true symbol_level = 1 Here are the errors: Generating files... ERROR Input to targets not generated by a dependency. The file: //out/GN_Asan/lib/libc++.so is listed as an input or source for the targets: //chrome/installer/linux:stable_deb //chrome/installer/linux:stable_rpm //chrome/installer/linux:beta_deb //chrome/installer/linux:beta_rpm //chrome/installer/linux:unstable_deb //chrome/installer/linux:unstable_rpm //chrome/installer/linux:trunk_deb //chrome/installer/linux:trunk_rpm //chrome/installer/linux:asan_deb //chrome/installer/linux:asan_rpm but no targets in the build generate that file. Committed: https://crrev.com/7e98c2b4a1ec78272cb23b318b069bfe6a66871d Cr-Commit-Position: refs/heads/master@{#431137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/installer/linux/BUILD.gn View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 31 (15 generated)
xhwang
I am not familiar with this code so I have no idea what I am ...
4 years, 1 month ago (2016-11-05 07:25:04 UTC) #4
Michael Moss
On 2016/11/05 07:25:04, xhwang_OOO_11_07 wrote: > I am not familiar with this code so I ...
4 years, 1 month ago (2016-11-08 15:18:41 UTC) #7
xhwang
+glider PTAL since mmoss isn't familiar with this code either. mmoss: Sorry for the lack ...
4 years, 1 month ago (2016-11-08 17:27:50 UTC) #11
xhwang
It seems glider@ is OOO. thestig: Could you please take a look at this CL? ...
4 years, 1 month ago (2016-11-09 21:16:51 UTC) #13
Michael Moss
On 2016/11/09 21:16:51, xhwang wrote: > It seems glider@ is OOO. > > thestig: Could ...
4 years, 1 month ago (2016-11-09 21:30:29 UTC) #14
Michael Moss
On 2016/11/09 21:16:51, xhwang wrote: > It seems glider@ is OOO. > > thestig: Could ...
4 years, 1 month ago (2016-11-09 21:30:32 UTC) #15
xhwang
Thanks! dpranke: Could you PTAL? Sorry for having so many reviewers added. Feel free to ...
4 years, 1 month ago (2016-11-09 21:36:52 UTC) #17
Dirk Pranke
Yup, this looks right. LGTM.
4 years, 1 month ago (2016-11-10 00:17:29 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478973002/1
4 years, 1 month ago (2016-11-10 00:23:30 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/300947)
4 years, 1 month ago (2016-11-10 00:33:07 UTC) #22
xhwang
mmoss: Can I get your OWNERS stamp?
4 years, 1 month ago (2016-11-10 00:35:07 UTC) #23
Lei Zhang
rs lgtm
4 years, 1 month ago (2016-11-10 00:42:56 UTC) #24
xhwang
Thank you all for the review!
4 years, 1 month ago (2016-11-10 00:43:55 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478973002/1
4 years, 1 month ago (2016-11-10 00:44:36 UTC) #27
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 01:55:07 UTC) #29
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 01:57:57 UTC) #31
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e98c2b4a1ec78272cb23b318b069bfe6a66871d
Cr-Commit-Position: refs/heads/master@{#431137}

Powered by Google App Engine
This is Rietveld 408576698