Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6167)

Unified Diff: chrome/installer/linux/BUILD.gn

Issue 2478973002: Fix libc++ dependency for linux installer (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/linux/BUILD.gn
diff --git a/chrome/installer/linux/BUILD.gn b/chrome/installer/linux/BUILD.gn
index 1394af3a9669a5282951fd57bc1340eacc2e48b5..b1258983886417a22c45d5eede761ef94c8b9505 100644
--- a/chrome/installer/linux/BUILD.gn
+++ b/chrome/installer/linux/BUILD.gn
@@ -200,6 +200,9 @@ group("installer_deps") {
if (!is_chromeos) {
public_deps += [ ":rpm_packaging_files" ]
}
+ if (use_custom_libcxx) {
+ public_deps += [ "//buildtools/third_party/libc++" ]
+ }
}
# Creates .deb and .rpm (RPM for non-ChromeOS only) installer packages.
@@ -246,8 +249,8 @@ template("linux_package") {
]
}
- if (is_asan) {
- packaging_files_binaries += [ "$root_out_dir/lib/libc++.so" ]
+ if (use_custom_libcxx) {
+ packaging_files_binaries += [ "$root_out_dir/libc++.so" ]
}
deb_target_name = "${target_name}_deb"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698