Completion with the new analysis driver.

Completion with the new analysis driver.

It works for top-levels, fields, locals, prefixed expressions.

Integration is not the most efficient - we resolve the full unit.
It works fine for files with about 1000 lines, about 50-70 ms.


We could slightly improve timing if we prioritize completion over
navigation and highlight notifications, which are currently prepared
and sent before completion.


In giant files like src/dart/element/element.dart, about 8500 lines,
it takes about 400 ms from typing to receiving completion. The theoretical
bottom bound for such files is about 70 ms - time that it required to
parse, create unlinked bundle, ensure that the API signature is the
same, load linked bundles and prepare to resynthesize. On top of this
goes any time required to resolve a single method and completion itself.


R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/fc30904a397611e1fd8b991f5a4d38e4150439f4

[Paul Berry, 2016-11-06 13:25:36]

lgtm

https://codereview.chromium.org/2478963002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/provisional/completion/completion_core.dart
(right):

https://codereview.chromium.org/2478963002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/completion/completion_core.dart:74:
AnalysisResult get result;
Document this public getter.

https://codereview.chromium.org/2478963002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart
(right):

https://codereview.chromium.org/2478963002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart:214:
: request.context.getContents(request.source).data;
To preserve null safety, this needs to be "?.data".

[Brian Wilkerson, 2016-11-06 17:54:02]

lgtm

https://codereview.chromium.org/2478963002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/domain_completion.dart (right):

https://codereview.chromium.org/2478963002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/domain_completion.dart:142: if
(server.options.enableNewAnalysisDriver) {
How are the error conditions (file not analyzed, invalid parameters) being
handled?

[scheglov, 2016-11-06 18:45:33]

https://codereview.chromium.org/2478963002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/domain_completion.dart (right):

https://codereview.chromium.org/2478963002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/domain_completion.dart:142: if
(server.options.enableNewAnalysisDriver) {
On 2016/11/06 17:54:02, Brian Wilkerson wrote:
> How are the error conditions (file not analyzed, invalid parameters) being
> handled?

I added handling of these error conditions.

https://codereview.chromium.org/2478963002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/provisional/completion/completion_core.dart
(right):

https://codereview.chromium.org/2478963002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/completion/completion_core.dart:74:
AnalysisResult get result;
On 2016/11/06 13:25:36, Paul Berry wrote:
> Document this public getter.

Done.

https://codereview.chromium.org/2478963002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart
(right):

https://codereview.chromium.org/2478963002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart:214:
: request.context.getContents(request.source).data;
On 2016/11/06 13:25:36, Paul Berry wrote:
> To preserve null safety, this needs to be "?.data".

Done.

[scheglov, 2016-11-06 18:45:52]

Description was changed from

==========
Completion with the new analysis driver.

It works for top-levels, fields, locals, prefixed expressions.

Integration is not the most efficient - we resolve the full unit.
It works fine for files with about 1000 lines, about 50-70 ms.


We could slightly improve timing if we prioritize completion over
navigation and highlight notifications, which are currently prepared
and sent before completion.


In giant files like src/dart/element/element.dart, about 8500 lines,
it takes about 400 ms from typing to receiving completion. The theoretical
bottom bound for such files is about 70 ms - time that it required to
parse, create unlinked bundle, ensure that the API signature is the
same, load linked bundles and prepare to resynthesize. On top of this
goes any time required to resolve a single method and completion itself.


R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Completion with the new analysis driver.

It works for top-levels, fields, locals, prefixed expressions.

Integration is not the most efficient - we resolve the full unit.
It works fine for files with about 1000 lines, about 50-70 ms.


We could slightly improve timing if we prioritize completion over
navigation and highlight notifications, which are currently prepared
and sent before completion.


In giant files like src/dart/element/element.dart, about 8500 lines,
it takes about 400 ms from typing to receiving completion. The theoretical
bottom bound for such files is about 70 ms - time that it required to
parse, create unlinked bundle, ensure that the API signature is the
same, load linked bundles and prepare to resynthesize. On top of this
goes any time required to resolve a single method and completion itself.


R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/fc30904a397611e1fd8b991f5a4d38e4150439f4
==========

[scheglov, 2016-11-06 18:45:53]

Committed patchset #2 (id:20001) manually as
fc30904a397611e1fd8b991f5a4d38e4150439f4 (presubmit successful).