Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: pkg/analysis_server/test/domain_completion_test.dart

Issue 2478963002: Completion with the new analysis driver. (Closed)
Patch Set: Fixes for review comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/domain_completion_test.dart
diff --git a/pkg/analysis_server/test/domain_completion_test.dart b/pkg/analysis_server/test/domain_completion_test.dart
index ef51507e5ab0148c6d47799e692fa2707b9c9880..b3d85f2f87af8fc236d002b7c8bb7667fb65af04 100644
--- a/pkg/analysis_server/test/domain_completion_test.dart
+++ b/pkg/analysis_server/test/domain_completion_test.dart
@@ -123,13 +123,13 @@ class CompletionDomainHandlerTest extends AbstractCompletionDomainTest {
c^''');
// Make a request for suggestions
- Request request =
+ Request request1 =
new CompletionGetSuggestionsParams(testFile, completionOffset)
.toRequest('7');
- Response response = handleSuccessfulRequest(request);
- var result1 = new CompletionGetSuggestionsResult.fromResponse(response);
+ Response response1 = await waitResponse(request1);
+ var result1 = new CompletionGetSuggestionsResult.fromResponse(response1);
var completionId1 = result1.id;
- assertValidId(response.id);
+ assertValidId(completionId1);
// Perform some analysis but assert that no suggestions have yet been made
completionId = completionId1;
@@ -141,7 +141,7 @@ class CompletionDomainHandlerTest extends AbstractCompletionDomainTest {
Request request2 =
new CompletionGetSuggestionsParams(testFile, completionOffset)
.toRequest('8');
- Response response2 = handleSuccessfulRequest(request2);
+ Response response2 = await waitResponse(request2);
var result2 = new CompletionGetSuggestionsResult.fromResponse(response2);
var completionId2 = result2.id;
assertValidId(completionId2);
@@ -164,7 +164,7 @@ class CompletionDomainHandlerTest extends AbstractCompletionDomainTest {
Request request =
new CompletionGetSuggestionsParams(testFile, completionOffset)
.toRequest('0');
- Response response = handleSuccessfulRequest(request);
+ Response response = await waitResponse(request);
completionId = response.id;
assertValidId(completionId);
@@ -227,7 +227,7 @@ class CompletionDomainHandlerTest extends AbstractCompletionDomainTest {
{testFile: new AddContentOverlay(revisedContent)}).toRequest('add1'));
// Request code completion immediately after edit
- Response response = handleSuccessfulRequest(
+ Response response = await waitResponse(
new CompletionGetSuggestionsParams(testFile, completionOffset)
.toRequest('0'));
completionId = response.id;
@@ -466,12 +466,12 @@ class B extends A {
});
}
- test_offset_past_eof() {
+ test_offset_past_eof() async {
addTestFile('main() { }', offset: 300);
Request request =
new CompletionGetSuggestionsParams(testFile, completionOffset)
.toRequest('0');
- Response response = handler.handleRequest(request);
+ Response response = await waitResponse(request);
expect(response.id, '0');
expect(response.error.code, RequestErrorCode.INVALID_PARAMETER);
}

Powered by Google App Engine
This is Rietveld 408576698