Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1735)

Unified Diff: chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.h

Issue 2478903002: DRP metrics observer stop observing after hidden (Closed)
Patch Set: bmcquade comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.h
index 9fa21537d803cb9999d9785fdeaec389902b66ab..0bbb996da802665ef5483fc22925e23af705bf12 100644
--- a/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.h
@@ -23,21 +23,23 @@ extern const char kHttpEngagementHistogram[];
class HttpsEngagementPageLoadMetricsObserver
: public page_load_metrics::PageLoadMetricsObserver {
public:
explicit HttpsEngagementPageLoadMetricsObserver(
content::BrowserContext* context);
// page_load_metrics::PageLoadMetricsObserver:
ObservePolicy OnStart(content::NavigationHandle* navigation_handle,
const GURL& currently_committed_url,
bool started_in_foreground) override;
- ObservePolicy OnHidden() override;
+ ObservePolicy OnHidden(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& extra_info) override;
ObservePolicy OnShown() override;
void OnComplete(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
private:
bool currently_in_foreground_;
base::TimeDelta foreground_time_;
base::TimeTicks last_time_shown_;
HttpsEngagementService* engagement_service_;

Powered by Google App Engine
This is Rietveld 408576698