Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc

Issue 2478903002: DRP metrics observer stop observing after hidden (Closed)
Patch Set: bmcquade comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc
index 19635211f3d007ade71c59e2c1929deb75c8fcbe..352d74f957eed6e72b50faa954b8ee4fd5e56a53 100644
--- a/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc
@@ -24,21 +24,23 @@ page_load_metrics::PageLoadMetricsObserver::ObservePolicy
HttpsEngagementPageLoadMetricsObserver::OnStart(
content::NavigationHandle* navigation_handle,
const GURL& currently_committed_url,
bool started_in_foreground) {
if (started_in_foreground)
OnShown();
return CONTINUE_OBSERVING;
}
page_load_metrics::PageLoadMetricsObserver::ObservePolicy
-HttpsEngagementPageLoadMetricsObserver::OnHidden() {
+HttpsEngagementPageLoadMetricsObserver::OnHidden(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& extra_info) {
if (currently_in_foreground_) {
foreground_time_ += base::TimeTicks::Now() - last_time_shown_;
currently_in_foreground_ = false;
}
return CONTINUE_OBSERVING;
}
page_load_metrics::PageLoadMetricsObserver::ObservePolicy
HttpsEngagementPageLoadMetricsObserver::OnShown() {
last_time_shown_ = base::TimeTicks::Now();
@@ -52,21 +54,21 @@ void HttpsEngagementPageLoadMetricsObserver::OnComplete(
if (!extra_info.committed_url.is_valid() ||
extra_info.committed_url.is_empty()) {
return;
}
// Don't record anything if the user never saw it.
if (!currently_in_foreground_ && foreground_time_.is_zero())
return;
if (currently_in_foreground_)
- OnHidden();
+ OnHidden(timing, extra_info);
if (extra_info.committed_url.SchemeIs(url::kHttpsScheme)) {
if (engagement_service_)
engagement_service_->RecordTimeOnPage(foreground_time_,
HttpsEngagementService::HTTPS);
UMA_HISTOGRAM_LONG_TIMES_100(internal::kHttpsEngagementHistogram,
foreground_time_);
} else if (extra_info.committed_url.SchemeIs(url::kHttpScheme)) {
if (engagement_service_)
engagement_service_->RecordTimeOnPage(foreground_time_,

Powered by Google App Engine
This is Rietveld 408576698