Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: tests/language/bad_constructor_test.dart

Issue 24789003: Fix test failure expectations and update status files. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language/bad_constructor_test.dart
===================================================================
--- tests/language/bad_constructor_test.dart (revision 27958)
+++ tests/language/bad_constructor_test.dart (working copy)
@@ -5,7 +5,7 @@
class A {
// Constructor may not be static.
- static A(); /// 00: compile-time error
+ static A() { } /// 00: compile-time error
hausner 2013/09/26 21:36:05 Why the change to { }?
regis 2013/09/26 22:12:26 Already replied to Ivan. Anyway, reverted here and
// Factory may not be static.
static factory A() { return null; } /// 01: compile-time error
@@ -14,10 +14,10 @@
var m;
A.m() { m = 0; } /// 04: compile-time error
- set q(var value) { m = q; }
- A.q(); /// 05: compile-time error
+ set q(var value) { m = q; } // No name conflict with q=.
+ A.q() { } /// 05: runtime error
hausner 2013/09/26 21:36:05 Why is this a runtime error? Can you add a comment
regis 2013/09/26 22:12:26 Done.
- A.foo() : m = 0; /// 06: compile-time error
+ A.foo() : m = 0 { } /// 06: compile-time error
hausner 2013/09/26 21:36:05 Why the change to empty body? A semicolon means em
regis 2013/09/26 22:12:26 Done.
int foo(int a, int b) => a + b * m;
}
« no previous file with comments | « no previous file | tests/language/getter_no_setter_test.dart » ('j') | tests/lib/mirrors/library_metadata2_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698