Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2478813002: When an Isolate is configured to use lockers, foreground tasks need to lock (Closed)

Created:
4 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
4 years, 1 month ago
Reviewers:
ulan
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When an Isolate is configured to use lockers, foreground tasks need to lock BUG=655635 R=ulan@chromium.org Committed: https://crrev.com/76acff10b8e325a18d490a5ef9f6c2fc99878d57 Cr-Commit-Position: refs/heads/master@{#430547}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Patch Set 3 : updates #

Patch Set 4 : updates #

Patch Set 5 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -10 lines) Patch
M gin/isolate_holder.cc View 1 chunk +1 line, -1 line 0 comments Download
M gin/per_isolate_data.h View 4 chunks +7 lines, -1 line 0 comments Download
M gin/per_isolate_data.cc View 1 chunk +3 lines, -1 line 0 comments Download
M gin/v8_platform.cc View 1 2 3 4 2 chunks +53 lines, -7 lines 0 comments Download

Messages

Total messages: 33 (18 generated)
jochen (gone - plz use gerrit)
4 years, 1 month ago (2016-11-04 14:19:22 UTC) #1
ulan
https://codereview.chromium.org/2478813002/diff/1/gin/v8_platform.cc File gin/v8_platform.cc (right): https://codereview.chromium.org/2478813002/diff/1/gin/v8_platform.cc#newcode57 gin/v8_platform.cc:57: PerIsolateData* data = PerIsolateData::From(isolate); The same change should apply ...
4 years, 1 month ago (2016-11-04 14:28:30 UTC) #4
jochen (gone - plz use gerrit)
ptal
4 years, 1 month ago (2016-11-04 14:37:22 UTC) #7
ulan
lgtm
4 years, 1 month ago (2016-11-04 14:50:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478813002/20001
4 years, 1 month ago (2016-11-04 14:51:25 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/174478)
4 years, 1 month ago (2016-11-04 15:22:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478813002/40001
4 years, 1 month ago (2016-11-07 18:50:39 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/267742)
4 years, 1 month ago (2016-11-07 20:03:38 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478813002/60001
4 years, 1 month ago (2016-11-07 22:58:46 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/256174) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-11-07 23:08:37 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478813002/80001
4 years, 1 month ago (2016-11-07 23:14:27 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/327223)
4 years, 1 month ago (2016-11-08 00:38:42 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478813002/80001
4 years, 1 month ago (2016-11-08 07:33:12 UTC) #30
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-08 08:21:03 UTC) #31
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 08:26:03 UTC) #33
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/76acff10b8e325a18d490a5ef9f6c2fc99878d57
Cr-Commit-Position: refs/heads/master@{#430547}

Powered by Google App Engine
This is Rietveld 408576698