|
|
Created:
4 years, 1 month ago by jochen (gone - plz use gerrit) Modified:
4 years, 1 month ago Reviewers:
ulan CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWhen an Isolate is configured to use lockers, foreground tasks need to lock
BUG=655635
R=ulan@chromium.org
Committed: https://crrev.com/76acff10b8e325a18d490a5ef9f6c2fc99878d57
Cr-Commit-Position: refs/heads/master@{#430547}
Patch Set 1 #
Total comments: 1
Patch Set 2 : updates #Patch Set 3 : updates #Patch Set 4 : updates #Patch Set 5 : updates #
Messages
Total messages: 33 (18 generated)
The CQ bit was checked by jochen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2478813002/diff/1/gin/v8_platform.cc File gin/v8_platform.cc (right): https://codereview.chromium.org/2478813002/diff/1/gin/v8_platform.cc#newcode57 gin/v8_platform.cc:57: PerIsolateData* data = PerIsolateData::From(isolate); The same change should apply to other Call*OnForegroundThread functions?
The CQ bit was checked by jochen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ptal
lgtm
The CQ bit was unchecked by jochen@chromium.org
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by jochen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org Link to the patchset: https://codereview.chromium.org/2478813002/#ps40001 (title: "updates")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jochen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org Link to the patchset: https://codereview.chromium.org/2478813002/#ps60001 (title: "updates")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by jochen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org Link to the patchset: https://codereview.chromium.org/2478813002/#ps80001 (title: "updates")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== When an Isolate is configured to use lockers, foreground tasks need to lock BUG=655635 R=ulan@chromium.org ========== to ========== When an Isolate is configured to use lockers, foreground tasks need to lock BUG=655635 R=ulan@chromium.org Committed: https://crrev.com/76acff10b8e325a18d490a5ef9f6c2fc99878d57 Cr-Commit-Position: refs/heads/master@{#430547} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/76acff10b8e325a18d490a5ef9f6c2fc99878d57 Cr-Commit-Position: refs/heads/master@{#430547} |