When an Isolate is configured to use lockers, foreground tasks need to lock

gin/v8_platform.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gin/public/v8_platform.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/sys_info.h"
 #include "base/threading/worker_pool.h"
 #include "base/trace_event/trace_event.h"
 #include "gin/per_isolate_data.h"
 
 namespace gin {
 
 namespace {
 
 base::LazyInstance<V8Platform>::Leaky g_v8_platform = LAZY_INSTANCE_INITIALIZER;
 
+void RunWithLocker(v8::Isolate* isolate, v8::Task* task) {
+  v8::Locker lock(isolate);
+  task->Run();
+}
+
+class IdleTaskWithLocker : public v8::IdleTask {
+ public:
+  IdleTaskWithLocker(v8::Isolate* isolate, v8::IdleTask* task)
+      : isolate_(isolate), task_(task) {}
+
+  ~IdleTaskWithLocker() override = default;
+
+  // v8::IdleTask implementation.
+  void Run(double deadline_in_seconds) override {
+    v8::Locker lock(isolate_);
+    task_->Run(deadline_in_seconds);
+  }
+
+ private:
+  v8::Isolate* isolate_;
+  std::unique_ptr<v8::IdleTask> task_;
+
+  DISALLOW_COPY_AND_ASSIGN(IdleTaskWithLocker);
+};
+
 }  // namespace
 
 // static
 V8Platform* V8Platform::Get() { return g_v8_platform.Pointer(); }
 
 V8Platform::V8Platform() {}
 
 V8Platform::~V8Platform() {}
 
 size_t V8Platform::NumberOfAvailableBackgroundThreads() {
@@ skipping 12 matching lines @@
 void V8Platform::CallOnBackgroundThread(
     v8::Task* task,
     v8::Platform::ExpectedRuntime expected_runtime) {
   base::WorkerPool::PostTask(
       FROM_HERE,
       base::Bind(&v8::Task::Run, base::Owned(task)),
       expected_runtime == v8::Platform::kLongRunningTask);
 }
 
 void V8Platform::CallOnForegroundThread(v8::Isolate* isolate, v8::Task* task) {
-  PerIsolateData::From(isolate)->task_runner()->PostTask(
-      FROM_HERE, base::Bind(&v8::Task::Run, base::Owned(task)));
+  PerIsolateData* data = PerIsolateData::From(isolate);
+  if (data->access_mode() == IsolateHolder::kUseLocker) {
+    data->task_runner()->PostTask(
+        FROM_HERE, base::Bind(RunWithLocker, base::Unretained(isolate),
+                              base::Owned(task)));
+  } else {
+    data->task_runner()->PostTask(
+        FROM_HERE, base::Bind(&v8::Task::Run, base::Owned(task)));
+  }
 }
 
 void V8Platform::CallDelayedOnForegroundThread(v8::Isolate* isolate,
                                                v8::Task* task,
                                                double delay_in_seconds) {
-  PerIsolateData::From(isolate)->task_runner()->PostDelayedTask(
-      FROM_HERE, base::Bind(&v8::Task::Run, base::Owned(task)),
-      base::TimeDelta::FromSecondsD(delay_in_seconds));
+  PerIsolateData* data = PerIsolateData::From(isolate);
+  if (data->access_mode() == IsolateHolder::kUseLocker) {
+    data->task_runner()->PostDelayedTask(
+        FROM_HERE,
+        base::Bind(RunWithLocker, base::Unretained(isolate), base::Owned(task)),
+        base::TimeDelta::FromSecondsD(delay_in_seconds));
+  } else {
+    data->task_runner()->PostDelayedTask(
+        FROM_HERE, base::Bind(&v8::Task::Run, base::Owned(task)),
+        base::TimeDelta::FromSecondsD(delay_in_seconds));
+  }
 }
 
 void V8Platform::CallIdleOnForegroundThread(v8::Isolate* isolate,
                                             v8::IdleTask* task) {
-  DCHECK(PerIsolateData::From(isolate)->idle_task_runner());
-  PerIsolateData::From(isolate)->idle_task_runner()->PostIdleTask(task);
+  PerIsolateData* data = PerIsolateData::From(isolate);
+  DCHECK(data->idle_task_runner());
+  if (data->access_mode() == IsolateHolder::kUseLocker) {
+    data->idle_task_runner()->PostIdleTask(
+        new IdleTaskWithLocker(isolate, task));
+  } else {
+    data->idle_task_runner()->PostIdleTask(task);
+  }
 }
 
 bool V8Platform::IdleTasksEnabled(v8::Isolate* isolate) {
   return PerIsolateData::From(isolate)->idle_task_runner() != nullptr;
 }
 
 double V8Platform::MonotonicallyIncreasingTime() {
   return base::TimeTicks::Now().ToInternalValue() /
       static_cast<double>(base::Time::kMicrosecondsPerSecond);
 }
@@ skipping 127 matching lines @@
     v8::Platform::TraceStateObserver* observer) {
   g_trace_state_dispatcher.Get().AddObserver(observer);
 }
 
 void V8Platform::RemoveTraceStateObserver(
     v8::Platform::TraceStateObserver* observer) {
   g_trace_state_dispatcher.Get().RemoveObserver(observer);
 }
 
 }  // namespace gin