third_party/WebKit/Source/wtf/text/TextEncoding.h - Issue 2478653002: Don't initialize ICU replacement character for UTF-32 encodings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/TextEncoding.h

Issue 2478653002: Don't initialize ICU replacement character for UTF-32 encodings (Closed)

Patch Set: Don't use zero-length array initializer, to keep MSVC happy Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/TextEncoding.h

diff --git a/third_party/WebKit/Source/wtf/text/TextEncoding.h b/third_party/WebKit/Source/wtf/text/TextEncoding.h

index d81a83b04f4a30c9305843e23d57f147dd2f19ff..f7285959d6f448ef41f092f9b5ba05e3f75aedfb 100644

--- a/third_party/WebKit/Source/wtf/text/TextEncoding.h

+++ b/third_party/WebKit/Source/wtf/text/TextEncoding.h

@@ -78,6 +78,7 @@ WTF_EXPORT const TextEncoding& ASCIIEncoding();

WTF_EXPORT const TextEncoding& Latin1Encoding();

WTF_EXPORT const TextEncoding& UTF16BigEndianEncoding();

WTF_EXPORT const TextEncoding& UTF16LittleEndianEncoding();

+WTF_EXPORT const TextEncoding& UTF32Encoding();

WTF_EXPORT const TextEncoding& UTF32BigEndianEncoding();

WTF_EXPORT const TextEncoding& UTF32LittleEndianEncoding();

WTF_EXPORT const TextEncoding& UTF8Encoding();

@@ -89,6 +90,7 @@ using WTF::ASCIIEncoding;

using WTF::Latin1Encoding;

using WTF::UTF16BigEndianEncoding;

using WTF::UTF16LittleEndianEncoding;

+using WTF::UTF32Encoding;

using WTF::UTF32BigEndianEncoding;

using WTF::UTF32LittleEndianEncoding;

using WTF::UTF8Encoding;