Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: third_party/WebKit/Source/wtf/text/TextEncoding.cpp

Issue 2478653002: Don't initialize ICU replacement character for UTF-32 encodings (Closed)
Patch Set: Don't use zero-length array initializer, to keep MSVC happy Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/wtf/text/TextEncoding.cpp
diff --git a/third_party/WebKit/Source/wtf/text/TextEncoding.cpp b/third_party/WebKit/Source/wtf/text/TextEncoding.cpp
index 69e1e20530bde606e07bd9b84092d01d6067febd..10e62ca03e5f9a0c81aff4a0c198104ee49266ce 100644
--- a/third_party/WebKit/Source/wtf/text/TextEncoding.cpp
+++ b/third_party/WebKit/Source/wtf/text/TextEncoding.cpp
@@ -101,7 +101,7 @@ bool TextEncoding::isNonByteBasedEncoding() const {
}
return *this == UTF16LittleEndianEncoding() ||
- *this == UTF16BigEndianEncoding() ||
+ *this == UTF16BigEndianEncoding() || *this == UTF32Encoding() ||
*this == UTF32BigEndianEncoding() ||
*this == UTF32LittleEndianEncoding();
}
@@ -156,6 +156,13 @@ const TextEncoding& UTF16LittleEndianEncoding() {
return globalUTF16LittleEndianEncoding;
}
+// UTF-32 is UTF-32LE with an implicit BOM.
+const TextEncoding& UTF32Encoding() {
+ DEFINE_THREAD_SAFE_STATIC_LOCAL(const TextEncoding, globalUTF32Encoding,
+ new TextEncoding("UTF-32"));
+ return globalUTF32Encoding;
+}
+
const TextEncoding& UTF32BigEndianEncoding() {
DEFINE_THREAD_SAFE_STATIC_LOCAL(const TextEncoding,
globalUTF32BigEndianEncoding,
« no previous file with comments | « third_party/WebKit/Source/wtf/text/TextEncoding.h ('k') | third_party/WebKit/Source/wtf/text/TextEncodingTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698