third_party/WebKit/Source/wtf/text/TextCodecICU.h - Issue 2478653002: Don't initialize ICU replacement character for UTF-32 encodings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/TextCodecICU.h

Issue 2478653002: Don't initialize ICU replacement character for UTF-32 encodings (Closed)

Patch Set: Add tests for TextEncoding methods Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/TextCodecICU.h

diff --git a/third_party/WebKit/Source/wtf/text/TextCodecICU.h b/third_party/WebKit/Source/wtf/text/TextCodecICU.h

index 52cb17b594627fca814813bebbdee20947d879ef..df150ccc15555a68d8884d6bd1dafccbb58b8e97 100644

--- a/third_party/WebKit/Source/wtf/text/TextCodecICU.h

+++ b/third_party/WebKit/Source/wtf/text/TextCodecICU.h

@@ -87,6 +87,8 @@ class TextCodecICU final : public TextCodec {

#endif

FRIEND_TEST_ALL_PREFIXES(TextCodecICUTest, IgnorableCodePoint);

+ FRIEND_TEST_ALL_PREFIXES(TextCodecICUTest, UTF32AndQuestionMarks);

+ FRIEND_TEST_ALL_PREFIXES(TextCodecICUTest, UTF32Aliases);

};

struct ICUConverterWrapper {