third_party/WebKit/Source/wtf/BUILD.gn - Issue 2478653002: Don't initialize ICU replacement character for UTF-32 encodings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/BUILD.gn

Issue 2478653002: Don't initialize ICU replacement character for UTF-32 encodings (Closed)

Patch Set: Add tests for TextEncoding methods Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/BUILD.gn

diff --git a/third_party/WebKit/Source/wtf/BUILD.gn b/third_party/WebKit/Source/wtf/BUILD.gn

index f2fe8257cd9fa28d37cde5468a40552407ba3771..cbba7dd0e7361bde66648597f61f3db3cd30e1cc 100644

--- a/third_party/WebKit/Source/wtf/BUILD.gn

+++ b/third_party/WebKit/Source/wtf/BUILD.gn

@@ -341,6 +341,7 @@ test("wtf_unittests") {

"text/TextCodecTest.cpp",

"text/TextCodecUTF8Test.cpp",

"text/TextCodecUserDefinedTest.cpp",

+ "text/TextEncodingTest.cpp",

"text/WTFStringTest.cpp",

"typed_arrays/ArrayBufferBuilderTest.cpp",

]