[builtins] fix Allocate() call in ReduceStringIterator()

[builtins] fix Allocate() call in ReduceStringIterator()

Use a NumberConstant op rather than an Int32Constant to make assertions in
v8::internal::compiler::EscapeAnalysis::ProcessAllocation() happy.

BUG=v8:5598
R=bmeurer@chromium.org, franzih@chromium.org

Committed: https://crrev.com/cbadac55287c3770bb74a2e9ff2052fa5d96874e
Cr-Commit-Position: refs/heads/master@{#40746}

[caitp, 2016-11-03 21:08:04]

The CQ bit was checked by caitp@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 21:08:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caitp, 2016-11-03 21:08:45]

quick fix for that nasty --turbo-escape crash. as noted on the bug, I don't
completely understand the reasoning behind these constants in the first place,
since it seems unrelated to the actual process of escape analysis

[Franzi, 2016-11-03 21:14:14]

I was about to submit the same fix. I think git cl got confused and replaced an
existing test file (test/mjsunit/compiler/regress-v8-5573.js). Or was that
intended?

[caitp, 2016-11-03 21:15:19]

On 2016/11/03 21:14:14, Franzi wrote:
> I was about to submit the same fix. I think git cl got confused and replaced
an
> existing test file (test/mjsunit/compiler/regress-v8-5573.js). Or was that
> intended?

rietveld frequently thinks that new JS tests are copied replacements of other JS
tests, but regress-v8-5573.js is still in the tree and is unaffected by this
patch.

[caitp, 2016-11-03 21:20:14]

On 2016/11/03 21:08:45, caitp wrote:
> quick fix for that nasty --turbo-escape crash. as noted on the bug, I don't
> completely understand the reasoning behind these constants in the first place,
> since it seems unrelated to the actual process of escape analysis

s/constants/assertions/

[commit-bot: I haz the power, 2016-11-03 21:42:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 21:42:06]

Dry run: This issue passed the CQ dry run.

[caitp, 2016-11-03 21:47:34]

fix formatting in test

[Benedikt Meurer, 2016-11-04 05:20:59]

Thanks, LGTM.

[Benedikt Meurer, 2016-11-04 05:21:03]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-11-04 05:21:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 05:44:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:21:48]

Description was changed from

==========
[builtins] fix Allocate() call in ReduceStringIterator()

Use a NumberConstant op rather than an Int32Constant to make assertions in
v8::internal::compiler::EscapeAnalysis::ProcessAllocation() happy.

BUG=v8:5598
R=bmeurer@chromium.org, franzih@chromium.org
==========

to

==========
[builtins] fix Allocate() call in ReduceStringIterator()

Use a NumberConstant op rather than an Int32Constant to make assertions in
v8::internal::compiler::EscapeAnalysis::ProcessAllocation() happy.

BUG=v8:5598
R=bmeurer@chromium.org, franzih@chromium.org

Committed: https://crrev.com/cbadac55287c3770bb74a2e9ff2052fa5d96874e
Cr-Commit-Position: refs/heads/master@{#40746}
==========

[commit-bot: I haz the power, 2016-11-17 22:21:49]

Patchset 2 (id:??) landed as
https://crrev.com/cbadac55287c3770bb74a2e9ff2052fa5d96874e
Cr-Commit-Position: refs/heads/master@{#40746}