Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: src/compiler/js-builtin-reducer.cc

Issue 2478643002: [builtins] fix Allocate() call in ReduceStringIterator() (Closed)
Patch Set: fix formatting in test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/es6/regress/regress-5598.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/js-builtin-reducer.h" 5 #include "src/compiler/js-builtin-reducer.h"
6 6
7 #include "src/compilation-dependencies.h" 7 #include "src/compilation-dependencies.h"
8 #include "src/compiler/access-builder.h" 8 #include "src/compiler/access-builder.h"
9 #include "src/compiler/js-graph.h" 9 #include "src/compiler/js-graph.h"
10 #include "src/compiler/node-matchers.h" 10 #include "src/compiler/node-matchers.h"
(...skipping 1029 matching lines...) Expand 10 before | Expand all | Expand 10 after
1040 context, context, effect); 1040 context, context, effect);
1041 Node* map = effect = graph()->NewNode( 1041 Node* map = effect = graph()->NewNode(
1042 javascript()->LoadContext(0, Context::STRING_ITERATOR_MAP_INDEX, true), 1042 javascript()->LoadContext(0, Context::STRING_ITERATOR_MAP_INDEX, true),
1043 native_context, native_context, effect); 1043 native_context, native_context, effect);
1044 1044
1045 // allocate new iterator 1045 // allocate new iterator
1046 effect = graph()->NewNode( 1046 effect = graph()->NewNode(
1047 common()->BeginRegion(RegionObservability::kNotObservable), effect); 1047 common()->BeginRegion(RegionObservability::kNotObservable), effect);
1048 Node* value = effect = graph()->NewNode( 1048 Node* value = effect = graph()->NewNode(
1049 simplified()->Allocate(NOT_TENURED), 1049 simplified()->Allocate(NOT_TENURED),
1050 jsgraph()->Int32Constant(JSStringIterator::kSize), effect, control); 1050 jsgraph()->Constant(JSStringIterator::kSize), effect, control);
1051 effect = graph()->NewNode(simplified()->StoreField(AccessBuilder::ForMap()), 1051 effect = graph()->NewNode(simplified()->StoreField(AccessBuilder::ForMap()),
1052 value, map, effect, control); 1052 value, map, effect, control);
1053 effect = graph()->NewNode( 1053 effect = graph()->NewNode(
1054 simplified()->StoreField(AccessBuilder::ForJSObjectProperties()), value, 1054 simplified()->StoreField(AccessBuilder::ForJSObjectProperties()), value,
1055 jsgraph()->EmptyFixedArrayConstant(), effect, control); 1055 jsgraph()->EmptyFixedArrayConstant(), effect, control);
1056 effect = graph()->NewNode( 1056 effect = graph()->NewNode(
1057 simplified()->StoreField(AccessBuilder::ForJSObjectElements()), value, 1057 simplified()->StoreField(AccessBuilder::ForJSObjectElements()), value,
1058 jsgraph()->EmptyFixedArrayConstant(), effect, control); 1058 jsgraph()->EmptyFixedArrayConstant(), effect, control);
1059 1059
1060 // attach the iterator to this string 1060 // attach the iterator to this string
(...skipping 385 matching lines...) Expand 10 before | Expand all | Expand 10 after
1446 return jsgraph()->simplified(); 1446 return jsgraph()->simplified();
1447 } 1447 }
1448 1448
1449 JSOperatorBuilder* JSBuiltinReducer::javascript() const { 1449 JSOperatorBuilder* JSBuiltinReducer::javascript() const {
1450 return jsgraph()->javascript(); 1450 return jsgraph()->javascript();
1451 } 1451 }
1452 1452
1453 } // namespace compiler 1453 } // namespace compiler
1454 } // namespace internal 1454 } // namespace internal
1455 } // namespace v8 1455 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/es6/regress/regress-5598.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698