Browser tests for starting a drag-and-drop out of an OOPIF.

Browser test for starting a drag-and-drop out of an OOPIF.

BUG=647249
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/67fdcaf94a4f3c647aef1ce6f82e88eb0ccfbead
Cr-Commit-Position: refs/heads/master@{#432314}

[Łukasz Anforowicz, 2016-11-08 19:55:49]

Description was changed from

==========
Browser tests for starting a drag-and-drop out of an OOPIF.

BUG=647249
==========

to

==========
Browser tests for starting a drag-and-drop out of an OOPIF.

BUG=647249
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Łukasz Anforowicz, 2016-11-08 19:55:58]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 19:56:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 20:07:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 20:07:24]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Łukasz Anforowicz, 2016-11-09 00:04:14]

Description was changed from

==========
Browser tests for starting a drag-and-drop out of an OOPIF.

BUG=647249
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Browser test for starting a drag-and-drop out of an OOPIF.

BUG=647249
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Łukasz Anforowicz, 2016-11-09 00:06:11]

Patchset #3 (id:40001) has been deleted

[Łukasz Anforowicz, 2016-11-09 00:13:20]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 00:13:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 00:56:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 00:56:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Łukasz Anforowicz, 2016-11-09 22:36:20]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 22:37:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2016-11-09 23:22:26]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 23:23:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 00:21:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 00:21:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Łukasz Anforowicz, 2016-11-10 19:24:52]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 19:25:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2016-11-10 19:26:24]

Nick, can you take a look please?

(note that some of the BUILD.gn changes depend on an earlier CL that is in
review right now)

https://codereview.chromium.org/2478583005/diff/60001/chrome/browser/drag_and...
File chrome/browser/drag_and_drop_browsertest.cc (right):

https://codereview.chromium.org/2478583005/diff/60001/chrome/browser/drag_and...
chrome/browser/drag_and_drop_browsertest.cc:448: content::RenderFrameHost*
GetFrameByName(const std::string& name_to_find) {
content::FrameTree::FindByName is not exposed via //content's public API.

https://codereview.chromium.org/2478583005/diff/80001/chrome/test/data/drag_a...
File chrome/test/data/drag_and_drop/page.html (left):

https://codereview.chromium.org/2478583005/diff/80001/chrome/test/data/drag_a...
chrome/test/data/drag_and_drop/page.html:45: </script>
This got removed, because navigating from within C++ makes it easier to control
when to continue the test.

[Łukasz Anforowicz, 2016-11-10 19:26:45]

lukasza@chromium.org changed reviewers:
+ nick@chromium.org

[Łukasz Anforowicz, 2016-11-10 19:26:46]

Nick, PTAL?

[commit-bot: I haz the power, 2016-11-10 20:46:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 20:46:42]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[Łukasz Anforowicz, 2016-11-11 19:51:35]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 19:51:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ncarter (slow), 2016-11-11 20:56:36]

https://codereview.chromium.org/2478583005/diff/140001/chrome/browser/drag_an...
File chrome/browser/drag_and_drop_browsertest.cc (right):

https://codereview.chromium.org/2478583005/diff/140001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:219: 
  // aura::client::DragDropClient:

https://codereview.chromium.org/2478583005/diff/140001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:576: #if defined(USE_OZONE)
Add a comment explaining why this is disabled in ozone.

https://codereview.chromium.org/2478583005/diff/140001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:620:
"http://.*:.*/image_decoding/droids.jpg"
Technically this could fail if the testserver happened to run on the default
port (the colon would be omitted). That's a non-issue right? The dynamic port
range starts at something like 1000?

https://codereview.chromium.org/2478583005/diff/140001/content/public/test/te...
File content/public/test/test_frame_navigation_observer.h (right):

https://codereview.chromium.org/2478583005/diff/140001/content/public/test/te...
content/public/test/test_frame_navigation_observer.h:22: // For
content_browsertests, which run on the UI thread, run a second
This comment needs to be updated slightly, since it's now safe to use this
outside of content_browsertests

https://codereview.chromium.org/2478583005/diff/140001/content/public/test/te...
content/public/test/test_frame_navigation_observer.h:28: // navigations
performed in the specified |frame|.
Navigation might actually destroy |frame| (if it transfers to a new RFH), so
this comment should make it clear that that's actually okay.

https://codereview.chromium.org/2478583005/diff/140001/content/public/test/te...
content/public/test/test_frame_navigation_observer.h:29: explicit
TestFrameNavigationObserver(RenderFrameHost* frame);
Could this be a ToRenderFrameHost? That would allow it to accept a FrameTreeNode
too, which is actually a more appropriate parameter.

[commit-bot: I haz the power, 2016-11-11 22:26:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 22:27:00]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2016-11-14 17:43:00]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 17:44:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2016-11-14 17:52:33]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 17:52:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2016-11-14 17:53:22]

Thanks Nick.  Can you take another look please?

https://codereview.chromium.org/2478583005/diff/140001/chrome/browser/drag_an...
File chrome/browser/drag_and_drop_browsertest.cc (right):

https://codereview.chromium.org/2478583005/diff/140001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:219: 
On 2016/11/11 20:56:36, ncarter wrote:
>   // aura::client::DragDropClient:

Done.

https://codereview.chromium.org/2478583005/diff/140001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:576: #if defined(USE_OZONE)
On 2016/11/11 20:56:36, ncarter wrote:
> Add a comment explaining why this is disabled in ozone.

Done.  I've opened https://crbug.com/665042.  I think the fix should be simple,
but I'll postpone it to a follow-up CL, to make sure the test lands as soon as
possible (to help with Paul's efforts + to unblock other CLs like the one to
parametrize tests to test both with same-site and cross-site subframes).

https://codereview.chromium.org/2478583005/diff/140001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:620:
"http://.*:.*/image_decoding/droids.jpg"
On 2016/11/11 20:56:36, ncarter wrote:
> Technically this could fail if the testserver happened to run on the default
> port (the colon would be omitted). That's a non-issue right? The dynamic port
> range starts at something like 1000?

I guess I can get rid of the colon - this will simplify the test a bit without a
big loss in the power the test assertion.

https://codereview.chromium.org/2478583005/diff/140001/content/public/test/te...
File content/public/test/test_frame_navigation_observer.h (right):

https://codereview.chromium.org/2478583005/diff/140001/content/public/test/te...
content/public/test/test_frame_navigation_observer.h:22: // For
content_browsertests, which run on the UI thread, run a second
On 2016/11/11 20:56:36, ncarter wrote:
> This comment needs to be updated slightly, since it's now safe to use this
> outside of content_browsertests

Ooops.  Done.

I got rid of the UI thread comment, but to make up for it added DCHECKs to the
implementation.

https://codereview.chromium.org/2478583005/diff/140001/content/public/test/te...
content/public/test/test_frame_navigation_observer.h:28: // navigations
performed in the specified |frame|.
On 2016/11/11 20:56:36, ncarter wrote:
> Navigation might actually destroy |frame| (if it transfers to a new RFH), so
> this comment should make it clear that that's actually okay.

Done (+ tried to wordsmith in a way that distinguishes between "frame tree node"
VS "frame" / "RenderFrameHost").

https://codereview.chromium.org/2478583005/diff/140001/content/public/test/te...
content/public/test/test_frame_navigation_observer.h:29: explicit
TestFrameNavigationObserver(RenderFrameHost* frame);
On 2016/11/11 20:56:36, ncarter wrote:
> Could this be a ToRenderFrameHost? That would allow it to accept a
FrameTreeNode
> too, which is actually a more appropriate parameter.

Good idea.  Done.

[Łukasz Anforowicz, 2016-11-14 17:54:04]

Patchset #9 (id:180001) has been deleted

[Łukasz Anforowicz, 2016-11-14 18:35:45]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 18:36:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 20:53:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 20:53:28]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[ncarter (slow), 2016-11-14 21:56:11]

lgtm, though you have red trybots

[Łukasz Anforowicz, 2016-11-14 22:14:12]

On 2016/11/14 21:56:11, ncarter wrote:
> lgtm, though you have red trybots

Thanks.

The linux_site_isolation redness is https://crbug.com/665058 and should go away
once the test suppression lands in https://crrev.com/2495383002.  The important
bit is that there are no interactive_ui_tests failures (which hopefully means
that the new filter file introduced by my CL is working okay).

The linux_chromium_gn_chromeos_rel redness doesn't seem related to my CL.  This
trybot is not part of CQ (it is probably from the time before GYP->GN switch)
and the failure is in bot setup, before even building.

[Łukasz Anforowicz, 2016-11-14 22:15:40]

lukasza@chromium.org changed reviewers:
+ sky@chromium.org

[Łukasz Anforowicz, 2016-11-14 22:15:41]

sky@, could you please take a look at the changes in chrome/browser/OWNERS?

[sky, 2016-11-15 00:37:55]

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
File chrome/browser/drag_and_drop_browsertest.cc (right):

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
This test is ui specific, and it looks like it's also aura specific. Can you
move to c/b/ui/views and add _aura to the name?

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:208: message_loop_runner_->Run();
Might StartDragAndDrop already have been called?

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:210: if (!drag_started_)
DCHECK?

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:213: *text = text_;
Why not copy the pointers and set the values directly there? By that I mean make
the text_ member a std::string* ?

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:221: 
no newline.

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:228: if (!drag_started_) {
DCHECK(!drag_started_)?

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:278: };
DISALLOW...

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:328: };
DISALLOW...

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:333: DOMDragEventVerifier(){};
no ';' and space between '()' and '{}'.

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:620:
EXPECT_TRUE(drag_start_waiter.WaitUntilDragStartIsIntercepted(
SHould this be an assert? If it fails is there really any point in continuing?

https://codereview.chromium.org/2478583005/diff/200001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2478583005/diff/200001/chrome/test/BUILD.gn#n...
chrome/test/BUILD.gn:523: sources += [ "../browser/drag_and_drop_browsertest.cc"
]
Name file with 'interactive_uitest' like the rest of the files?

[Łukasz Anforowicz, 2016-11-15 18:21:06]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 18:21:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2016-11-15 18:28:22]

Thanks sky@.  Can you take another look please?  I think (hope?) that the only
controversial thing left is how to treat the current test's dependency on aura
(i.e. whether to continue as-is OR whether to split aura-specific bits into
separate files OR maybe do something else).

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
File chrome/browser/drag_and_drop_browsertest.cc (right):

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
On 2016/11/15 00:37:55, sky wrote:
> This test is ui specific, and it looks like it's also aura specific. Can you
> move to c/b/ui/views and add _aura to the name?

Thanks for the suggestion.  I agree that it makes sense to move the new tests to
c/b/ui/views (given that the new test being added in this CL needs to simulate
the start of the drag and drop by going through ui-level simulation of the
mouse).

OTOH, the fact that the test today is implemented on top of aura is rather
accidental.  The test here mainly tests handling of drag-and-drop in //content
and Blink layers (to make sure drag-and-drop works across OOPIFs) - this
functionality needs to be hooked into aura, but routing mouse events across
multiple widgets should in general work across various UI platforms.  Ideally,
in the future the test would be amended to also work on Mac and/or Android.  I
think an Aura-only test is still a step in the right direction (and is
definitely needed to help prevent regressions in the drag-and-drop OOPIF support
that paulmeyer@ is working on and hopes to finish landing in the next week or
two).

So:

- I think I'd prefer to keep the test named in an aura-agnostic way

- I am open to suggestions for how to structure things, so that the
aura-specific things aren't mixed with ui-platform-agnostic stuff.  Maybe I
should move implementation of DragAndDropSimulator and DragStartWaiter classes
to an c/b/ui/views/drag_and_drop_test_utils_*aura*.cc while keeping non-virtual
(?) declarations of these classes in c/b/ui/views/drag_and_drop_test_utils.h.  I
haven't done that yet, because it seemed like an overkill given that 1)
currently there is *only* an aura implementation and 2) these classes are only
used from the 2 tests in drag_and_drop_browsertest.cc.

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:208: message_loop_runner_->Run();
On 2016/11/15 00:37:55, sky wrote:
> Might StartDragAndDrop already have been called?

Yes and this is okay - in this case Run will immediately exit because our
implementation of StartDragAndDrop calls message_loop_runner_->Quit().  This
pattern is used in multiple places in content/public/test/browser_test_utils.cc
so I assume it is okay to also use this pattern here (examples from
browser_test_utils.cc - TitleWatcher calls Quit from TitleWatcher::TestTitle and
calls Run from TitleWatcher::WaitAndGetTitle.

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:210: if (!drag_started_)
On 2016/11/15 00:37:55, sky wrote:
> DCHECK?

Done.

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:213: *text = text_;
On 2016/11/15 00:37:55, sky wrote:
> Why not copy the pointers and set the values directly there? By that I mean
make
> the text_ member a std::string* ?

I think I'd prefer to leave this as-is:

1. This allows std::string text variable (and other related variables) to be
declared closer to the point of usage (i.e. right before
WaitUntilDragStartIsIntercepted, instead of before declaration of
DragStartWaiter).

2. This matches the pattern of other waiters from
//content/public/test/browser_test_utils.cc (i.e. TitleWatcher::observed_title_,
InputMsgWatcher::ack_result_ and ack_source_).

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:221: 
On 2016/11/15 00:37:55, sky wrote:
> no newline.

Done.

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:228: if (!drag_started_) {
On 2016/11/15 00:37:55, sky wrote:
> DCHECK(!drag_started_)?

Hmmm... okay.  I thought that this class should be a generic util that doesn't
fail a test if 2 drag-and-drops start and end, one after the other (although the
only test that uses DragStartWaiter today is indeed expecting only a single
drag-start).

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:278: };
On 2016/11/15 00:37:55, sky wrote:
> DISALLOW...

Ooops.  Done.

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:328: };
On 2016/11/15 00:37:55, sky wrote:
> DISALLOW...

Done.

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:333: DOMDragEventVerifier(){};
On 2016/11/15 00:37:55, sky wrote:
> no ';' and space between '()' and '{}'.

Done.

https://codereview.chromium.org/2478583005/diff/200001/chrome/browser/drag_an...
chrome/browser/drag_and_drop_browsertest.cc:620:
EXPECT_TRUE(drag_start_waiter.WaitUntilDragStartIsIntercepted(
On 2016/11/15 00:37:55, sky wrote:
> SHould this be an assert? If it fails is there really any point in continuing?

N/A - after addressing earlier comments WaitUntilDragStartIsIntercepted doesn't
return a boolean anymore (because it is not possible for it to return until
drag-start actually happened).

https://codereview.chromium.org/2478583005/diff/200001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2478583005/diff/200001/chrome/test/BUILD.gn#n...
chrome/test/BUILD.gn:523: sources += [ "../browser/drag_and_drop_browsertest.cc"
]
On 2016/11/15 00:37:55, sky wrote:
> Name file with 'interactive_uitest' like the rest of the files?

Done.

[commit-bot: I haz the power, 2016-11-15 19:18:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 19:18:15]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[Łukasz Anforowicz, 2016-11-15 19:37:32]

https://codereview.chromium.org/2478583005/diff/260001/chrome/browser/ui/view...
File chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc (right):

https://codereview.chromium.org/2478583005/diff/260001/chrome/browser/ui/view...
chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc:593:
IN_PROC_BROWSER_TEST_F(DragAndDropBrowserTest, MAYBE_DragStartInFrame) {
Oh, and I am not anymore 100% sure if *BrowserTest suffix is right.  I think it
is (i.e. this is what is used in let's say
chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc), but
I've also seen *InteractiveTest or *UiTest suffixes being used.

And I am pretty sure that I want to continue using IN_PROC_BROWSER_TEST_* macros
(I don't want to immediately start a message loop like VIEW_TEST macro would).

[sky, 2016-11-15 20:46:23]

LGTM

[Łukasz Anforowicz, 2016-11-15 21:49:17]

On 2016/11/15 20:46:23, sky wrote:
> LGTM

Thanks.  I'll rebase one more time before landing (git cl upload doesn't
generate big enough context around diff/patch hunks and the changes in
testing/buildbot/chromium.fyi.json keep moving around and being applied to wrong
lines [i.e. to blimp tests rather than interactive_ui_tests]).

[Łukasz Anforowicz, 2016-11-15 21:53:45]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 21:54:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 22:56:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 22:56:39]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Łukasz Anforowicz, 2016-11-15 23:36:15]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-11-15 23:36:15]

The patchset sent to the CQ was uploaded after l-g-t-m from nick@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2478583005/#ps300001
(title: "Rebasing...")

[commit-bot: I haz the power, 2016-11-15 23:36:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 00:28:20]

Description was changed from

==========
Browser test for starting a drag-and-drop out of an OOPIF.

BUG=647249
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Browser test for starting a drag-and-drop out of an OOPIF.

BUG=647249
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-11-16 00:28:21]

Committed patchset #14 (id:300001)

[commit-bot: I haz the power, 2016-11-16 00:31:34]

Description was changed from

==========
Browser test for starting a drag-and-drop out of an OOPIF.

BUG=647249
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Browser test for starting a drag-and-drop out of an OOPIF.

BUG=647249
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/67fdcaf94a4f3c647aef1ce6f82e88eb0ccfbead
Cr-Commit-Position: refs/heads/master@{#432314}
==========

[commit-bot: I haz the power, 2016-11-16 00:31:36]

Patchset 14 (id:??) landed as
https://crrev.com/67fdcaf94a4f3c647aef1ce6f82e88eb0ccfbead
Cr-Commit-Position: refs/heads/master@{#432314}