Browser tests for starting a drag-and-drop out of an OOPIF.

content/public/test/test_frame_navigation_observer.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_TEST_TEST_FRAME_NAVIGATION_OBSERVER_H_
 #define CONTENT_TEST_TEST_FRAME_NAVIGATION_OBSERVER_H_
 
 #include <memory>
 #include <set>
 
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/test/test_utils.h"
 
 class GURL;
 
 namespace content {
-class FrameTreeNode;
-class WebContents;
+class RenderFrameHost;
 
 // For content_browsertests, which run on the UI thread, run a second

[ncarter (slow), 2016/11/11 20:56:36]

This comment needs to be updated slightly, since it's now safe to use this
outside of content_browsertests

[Łukasz Anforowicz, 2016/11/14 17:53:22]

Ooops.  Done.

I got rid of the UI thread comment, but to make up for it added DCHECKs to the
implementation.

 // MessageLoop and quit when the navigation in a specific frame (and all of its
 // subframes) has completed loading.
 class TestFrameNavigationObserver : public WebContentsObserver {
  public:
   // Create and register a new TestFrameNavigationObserver which will track
-  // navigations performed in the specified |node| of the frame tree.
-  explicit TestFrameNavigationObserver(FrameTreeNode* node);
+  // navigations performed in the specified |frame|.

[ncarter (slow), 2016/11/11 20:56:36]

Navigation might actually destroy |frame| (if it transfers to a new RFH), so
this comment should make it clear that that's actually okay.

[Łukasz Anforowicz, 2016/11/14 17:53:22]

Done (+ tried to wordsmith in a way that distinguishes between "frame tree node"
VS "frame" / "RenderFrameHost").

+  explicit TestFrameNavigationObserver(RenderFrameHost* frame);

[ncarter (slow), 2016/11/11 20:56:36]

Could this be a ToRenderFrameHost? That would allow it to accept a FrameTreeNode
too, which is actually a more appropriate parameter.

[Łukasz Anforowicz, 2016/11/14 17:53:22]

Good idea.  Done.

 
   ~TestFrameNavigationObserver() override;
 
   // Runs a nested message loop and blocks until the full load has
   // completed.
   void Wait();
 
   // Runs a nested message loop and blocks until the navigation in the
   // associated FrameTreeNode has committed.
   void WaitForCommit();
@@ skipping 25 matching lines @@
 
   // The MessageLoopRunner used to spin the message loop.
   scoped_refptr<MessageLoopRunner> message_loop_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(TestFrameNavigationObserver);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_TEST_TEST_FRAME_NAVIGATION_OBSERVER_H_