components/history/core/browser/url_utils.cc - Issue 2478573004: Convert GURL::{host,path} to GURL::{host_piece,path_piece} for ==.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/url_utils.cc

Issue 2478573004: Convert GURL::{host,path} to GURL::{host_piece,path_piece} for ==. (Closed)

Patch Set: rebase to #431874 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/url_utils.cc

diff --git a/components/history/core/browser/url_utils.cc b/components/history/core/browser/url_utils.cc

index 522af9b9689de999c1548d971abd660314b59078..307c89419bd927f433cdcfa4f80a9cbbb0c0daac 100644

--- a/components/history/core/browser/url_utils.cc

+++ b/components/history/core/browser/url_utils.cc

@@ -46,8 +46,8 @@ bool CanonicalURLStringCompare(const std::string& s1, const std::string& s2) {

}

bool HaveSameSchemeHostAndPort(const GURL&url1, const GURL& url2) {

- return url1.scheme() == url2.scheme() && url1.host() == url2.host() &&

- url1.port() == url2.port();

+ return url1.scheme_piece() == url2.scheme_piece() &&

+ url1.host_piece() == url2.host_piece() && url1.port() == url2.port();

}

bool IsPathPrefix(const std::string& p1, const std::string& p2) {