components/history/core/browser/history_match.cc - Issue 2478573004: Convert GURL::{host,path} to GURL::{host_piece,path_piece} for ==.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/history_match.cc

Issue 2478573004: Convert GURL::{host,path} to GURL::{host_piece,path_piece} for ==. (Closed)

Patch Set: rebase to #431874 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/history_match.cc

diff --git a/components/history/core/browser/history_match.cc b/components/history/core/browser/history_match.cc

index 6e252b9c4d25d60286516689dcf9c23b3e6ac1a4..ae9787bc21d1653d0a4aa6933be940342f1ca8a0 100644

--- a/components/history/core/browser/history_match.cc

+++ b/components/history/core/browser/history_match.cc

@@ -32,8 +32,8 @@ bool HistoryMatch::EqualsGURL(const HistoryMatch& h, const GURL& url) {

bool HistoryMatch::IsHostOnly() const {

const GURL& gurl = url_info.url();

DCHECK(gurl.is_valid());

- return (!gurl.has_path() || (gurl.path() == "/")) && !gurl.has_query() &&

- !gurl.has_ref();

+ return (!gurl.has_path() || (gurl.path_piece() == "/")) &&

+ !gurl.has_query() && !gurl.has_ref();

}

} // namespace history