DevTools: Substring autocomplete in Console and StylesSideBar.

DevTools: Substring autocomplete in Console and StylesSideBar.

Case insensitive matching as well as matching user entered text
in the middle of a suggestion.

BUG=660941
Committed: https://crrev.com/c2e553e4b38ed65bf11045c2e61895dc625e3dd5
Cr-Commit-Position: refs/heads/master@{#429819}

[einbinder, 2016-11-03 19:35:37]

einbinder@chromium.org changed reviewers:
+ lushnikov@chromium.org

[einbinder, 2016-11-03 19:35:38]

ptal

[einbinder, 2016-11-03 19:41:25]

The CQ bit was checked by einbinder@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 19:42:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 21:41:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 21:41:10]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-11-03 22:06:51]

lgtm % tests

https://codereview.chromium.org/2478563002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/elements/styles-3/style-autocomplete.html
(right):

https://codereview.chromium.org/2478563002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/elements/styles-3/style-autocomplete.html:59:
{
let's add some real tests?

https://codereview.chromium.org/2478563002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js
(right):

https://codereview.chromium.org/2478563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js:247:
var caseSensitivePrefix = [];
let's move this to where we use these

https://codereview.chromium.org/2478563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js:291:
}
I'm not convinced about JS case-insensetive autocomplete. But we can give it a
shot

https://codereview.chromium.org/2478563002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
(right):

https://codereview.chromium.org/2478563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:2916:
if (completion.startsWith(query))
var index = indexof...

[einbinder, 2016-11-03 23:12:14]

https://codereview.chromium.org/2478563002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/elements/styles-3/style-autocomplete.html
(right):

https://codereview.chromium.org/2478563002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/elements/styles-3/style-autocomplete.html:59:
{
On 2016/11/03 at 22:06:51, lushnikov wrote:
> let's add some real tests?

Done.

https://codereview.chromium.org/2478563002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js
(right):

https://codereview.chromium.org/2478563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js:247:
var caseSensitivePrefix = [];
On 2016/11/03 at 22:06:51, lushnikov wrote:
> let's move this to where we use these

Done.

https://codereview.chromium.org/2478563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js:291:
}
On 2016/11/03 at 22:06:51, lushnikov wrote:
> I'm not convinced about JS case-insensetive autocomplete. But we can give it a
shot

Yay!

https://codereview.chromium.org/2478563002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
(right):

https://codereview.chromium.org/2478563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:2916:
if (completion.startsWith(query))
On 2016/11/03 at 22:06:51, lushnikov wrote:
> var index = indexof...

Done.

[einbinder, 2016-11-03 23:12:16]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2016-11-03 23:12:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2478563002/#ps40001
(title: "tests")

[commit-bot: I haz the power, 2016-11-03 23:13:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 04:25:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 04:25:31]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[einbinder, 2016-11-04 05:51:18]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2016-11-04 05:51:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 06:56:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-04 06:59:08]

Description was changed from

==========
DevTools: Substring autocomplete in Console and StylesSideBar.

Case insensitive matching as well as matching user entered text
in the middle of a suggestion.

BUG=660941
==========

to

==========
DevTools: Substring autocomplete in Console and StylesSideBar.

Case insensitive matching as well as matching user entered text
in the middle of a suggestion.

BUG=660941

Committed: https://crrev.com/c2e553e4b38ed65bf11045c2e61895dc625e3dd5
Cr-Commit-Position: refs/heads/master@{#429819}
==========

[commit-bot: I haz the power, 2016-11-04 06:59:09]

Patchset 3 (id:??) landed as
https://crrev.com/c2e553e4b38ed65bf11045c2e61895dc625e3dd5
Cr-Commit-Position: refs/heads/master@{#429819}