Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2474143002: DevTools: Rename prefix to query in the context of autocomplete (Closed)

Created:
4 years, 1 month ago by einbinder
Modified:
4 years, 1 month ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Rename prefix to query in the context of autocomplete This is in preparation of autocomplete that doesn't just use the prefix to filter completions, but instead might search in the middle of completions. BUG=660941 Committed: https://crrev.com/8f86e28c9e681f4b9d252c6a555a973f8403a7e3 Cr-Commit-Position: refs/heads/master@{#429711}

Patch Set 1 #

Patch Set 2 : merge #

Total comments: 1

Messages

Total messages: 16 (8 generated)
einbinder
ptal
4 years, 1 month ago (2016-11-03 17:58:20 UTC) #3
einbinder
https://codereview.chromium.org/2474143002/diff/20001/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js (left): https://codereview.chromium.org/2474143002/diff/20001/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js#oldcode757 third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:757: section.addKey(shortcut.makeDescriptor(shortcut.Keys.Tab), WebInspector.UIString('Autocomplete common prefix')); We haven't had this functionality ...
4 years, 1 month ago (2016-11-03 17:59:06 UTC) #5
lushnikov
why do we do this? Could you please briefly motivate these changes in the patch ...
4 years, 1 month ago (2016-11-03 20:39:12 UTC) #8
einbinder
On 2016/11/03 at 20:39:12, lushnikov wrote: > why do we do this? Could you please ...
4 years, 1 month ago (2016-11-03 20:52:43 UTC) #10
lushnikov
lgtm
4 years, 1 month ago (2016-11-03 22:07:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474143002/20001
4 years, 1 month ago (2016-11-03 22:08:18 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 22:16:50 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 22:18:47 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8f86e28c9e681f4b9d252c6a555a973f8403a7e3
Cr-Commit-Position: refs/heads/master@{#429711}

Powered by Google App Engine
This is Rietveld 408576698