Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 247843003: Rerun clang-format on generated GPU command buffer files. (Closed)

Created:
6 years, 8 months ago by Zhenyao Mo
Modified:
6 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Rerun clang-format on generated GPU command buffer files. I think clang-format is updated to a newer version, thus the difference. We want to do this without changing the build script, so it's easier to review. I verified it's using the correct clang-format (the one in the update-to-date depot_tools) BUG= TEST=gpu_unittests R=piman@chromium.org

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4493 lines, -2004 lines) Patch
M gpu/command_buffer/client/client_context_state_impl_autogen.h View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 13 chunks +818 lines, -384 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 4 chunks +17 lines, -8 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 6 chunks +18 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 4 chunks +17 lines, -8 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 15 chunks +402 lines, -195 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 4 chunks +17 lines, -8 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 33 chunks +230 lines, -176 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +233 lines, -233 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 41 chunks +2463 lines, -851 lines 0 comments Download
M gpu/command_buffer/service/context_state_impl_autogen.h View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 7 chunks +21 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 25 chunks +75 lines, -25 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 6 chunks +139 lines, -69 lines 0 comments Download
M mojo/public/c/gles2/gles2_call_visitor_autogen.h View 4 chunks +39 lines, -32 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Zhenyao Mo
piman: can you stamp this?
6 years, 8 months ago (2014-04-22 18:21:32 UTC) #1
Zhenyao Mo
https://codereview.chromium.org/247843003/diff/1/mojo/public/c/gles2/gles2_call_visitor_autogen.h File mojo/public/c/gles2/gles2_call_visitor_autogen.h (right): https://codereview.chromium.org/247843003/diff/1/mojo/public/c/gles2/gles2_call_visitor_autogen.h#newcode206 mojo/public/c/gles2/gles2_call_visitor_autogen.h:206: GLsizei * length, I think this is against chromium ...
6 years, 8 months ago (2014-04-22 18:24:54 UTC) #2
piman
6 years, 8 months ago (2014-04-22 19:31:16 UTC) #3 
On Tue, Apr 22, 2014 at 11:24 AM, <zmo@chromium.org> wrote:

>
> https://codereview.chromium.org/247843003/diff/1/mojo/
> public/c/gles2/gles2_call_visitor_autogen.h
> File mojo/public/c/gles2/gles2_call_visitor_autogen.h (right):
>
> https://codereview.chromium.org/247843003/diff/1/mojo/
> public/c/gles2/gles2_call_visitor_autogen.h#newcode206
> mojo/public/c/gles2/gles2_call_visitor_autogen.h:206: GLsizei * length,
> I think this is against chromium style.  Who's the clang-format guy on
> the team?
>

I'd ask on chromium-dev

>
> https://codereview.chromium.org/247843003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698