Remove SurfaceSequence from mus client code.

Remove SurfaceSequence from mus client code.

This is a first step in replacing all SurfaceSequences in mus. We were
passing a sequence from WT to WTC and the client was storing it. The
client would later return the sequence. However, we never registered the
sequence as a dependency so it was one big no-op.

Remove all of the no-op code. Drop OnWindowSurfacedDetached() since it's
not needed now. Something along these lines will need to be added in the
future, but it will need to be synchronized with SubmitCompositorFrame()
so would need to be in a different interface anyways.

BUG=659227
Committed: https://crrev.com/8f4cf6a6f7c47173fe85f7f6022bd5f64b84eb04
Cr-Commit-Position: refs/heads/master@{#430841}

[kylechar, 2016-11-04 19:47:43]

Patchset #2 (id:20001) has been deleted

[kylechar, 2016-11-07 18:13:25]

Patchset #4 (id:80001) has been deleted

[kylechar, 2016-11-07 18:26:56]

Description was changed from

==========
Use surface references in mustash.

Replace SurfaceSequence dependencies with surface references in the mus
WS. We reuse the same code for when to add/remove a reference as we did
to add/remove a dependency, so behaviour should be identical.

No longer pass a SurfaceSequence from WT to WTC. This SurfaceSequence
wasn't actually useful, it was never added as a dependency on any
cc::Surfaces, so returning it had no impact on GC.

BUG=659227
==========

to

==========
Use surface references in mustash.

Replace SurfaceSequence dependencies with surface references in the mus
WS. We reuse the same code for when to add/remove a reference as we did
to add/remove a dependency, so surface lifetime should be identical.

No longer pass a SurfaceSequence from WT to WTC. This SurfaceSequence
wasn't actually useful, it was never added as a dependency on any
cc::Surfaces, so returning it had no impact on GC. Also get rid of
OnWindowSurfaceDetached() since it wasn't doing anything.

BUG=659227
==========

[kylechar, 2016-11-07 18:34:07]

kylechar@chromium.org changed reviewers:
+ fsamuel@chromium.org

[kylechar, 2016-11-07 18:34:08]

I'm going to start with a mechanical switch from SurfaceSequence to references
here instead of doing the full fix. Surface lifetime will be identical and it
simplifies adding proper lifetime management next.

[Fady Samuel, 2016-11-07 18:38:43]

lgtm

[kylechar, 2016-11-08 20:14:13]

Description was changed from

==========
Use surface references in mustash.

Replace SurfaceSequence dependencies with surface references in the mus
WS. We reuse the same code for when to add/remove a reference as we did
to add/remove a dependency, so surface lifetime should be identical.

No longer pass a SurfaceSequence from WT to WTC. This SurfaceSequence
wasn't actually useful, it was never added as a dependency on any
cc::Surfaces, so returning it had no impact on GC. Also get rid of
OnWindowSurfaceDetached() since it wasn't doing anything.

BUG=659227
==========

to

==========
Remove SurfaceSequence from mus client code.

This is a first step in replacing all SurfaceSequences in mus. We were
passing a sequence from WT to WTC and the client was storing it. The
client would later return the sequence. However, we never registered the
sequence as a dependency so was one big no-op.

Remove all of the no-op code. Drop OnWindowSurfacedDetached() since it's
not needed now. Something along these lines will need to be added in the
future, but it will need to be synchronized with SubmitCompositorFrame()
so would need to be in a different interface anyways.

BUG=659227
==========

[kylechar, 2016-11-08 20:14:24]

Description was changed from

==========
Remove SurfaceSequence from mus client code.

This is a first step in replacing all SurfaceSequences in mus. We were
passing a sequence from WT to WTC and the client was storing it. The
client would later return the sequence. However, we never registered the
sequence as a dependency so was one big no-op.

Remove all of the no-op code. Drop OnWindowSurfacedDetached() since it's
not needed now. Something along these lines will need to be added in the
future, but it will need to be synchronized with SubmitCompositorFrame()
so would need to be in a different interface anyways.

BUG=659227
==========

to

==========
Remove SurfaceSequence from mus client code.

This is a first step in replacing all SurfaceSequences in mus. We were
passing a sequence from WT to WTC and the client was storing it. The
client would later return the sequence. However, we never registered the
sequence as a dependency so was one big no-op.

Remove all of the no-op code. Drop OnWindowSurfacedDetached() since it's
not needed now. Something along these lines will need to be added in the
future, but it will need to be synchronized with SubmitCompositorFrame()
so would need to be in a different interface anyways.

BUG=659227
==========

[kylechar, 2016-11-08 20:16:20]

kylechar@chromium.org changed reviewers:
+ sky@chromium.org, tsepez@chromium.org

[kylechar, 2016-11-08 20:16:21]

fsamuel: Maybe take another look. I've removed the changes from FrameGenerator
and will follow up with them in another CL. This is just the cleanup code from
before that removes a bunch of no-op uses of SurfaceSequence.

sky: services/ui/* OWNERS
tsepez: mojom OWNERS

[Tom Sepez, 2016-11-08 20:22:01]

OWNERS LGTM

[Fady Samuel, 2016-11-08 20:56:54]

lgtm

[sky, 2016-11-09 00:08:25]

LGTM

[kylechar, 2016-11-09 00:36:04]

Description was changed from

==========
Remove SurfaceSequence from mus client code.

This is a first step in replacing all SurfaceSequences in mus. We were
passing a sequence from WT to WTC and the client was storing it. The
client would later return the sequence. However, we never registered the
sequence as a dependency so was one big no-op.

Remove all of the no-op code. Drop OnWindowSurfacedDetached() since it's
not needed now. Something along these lines will need to be added in the
future, but it will need to be synchronized with SubmitCompositorFrame()
so would need to be in a different interface anyways.

BUG=659227
==========

to

==========
Remove SurfaceSequence from mus client code.

This is a first step in replacing all SurfaceSequences in mus. We were
passing a sequence from WT to WTC and the client was storing it. The
client would later return the sequence. However, we never registered the
sequence as a dependency so it was one big no-op.

Remove all of the no-op code. Drop OnWindowSurfacedDetached() since it's
not needed now. Something along these lines will need to be added in the
future, but it will need to be synchronized with SubmitCompositorFrame()
so would need to be in a different interface anyways.

BUG=659227
==========

[kylechar, 2016-11-09 00:47:02]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 00:47:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 02:30:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 02:30:44]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-11-09 02:37:48]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2016-11-09 02:38:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 03:17:47]

Description was changed from

==========
Remove SurfaceSequence from mus client code.

This is a first step in replacing all SurfaceSequences in mus. We were
passing a sequence from WT to WTC and the client was storing it. The
client would later return the sequence. However, we never registered the
sequence as a dependency so it was one big no-op.

Remove all of the no-op code. Drop OnWindowSurfacedDetached() since it's
not needed now. Something along these lines will need to be added in the
future, but it will need to be synchronized with SubmitCompositorFrame()
so would need to be in a different interface anyways.

BUG=659227
==========

to

==========
Remove SurfaceSequence from mus client code.

This is a first step in replacing all SurfaceSequences in mus. We were
passing a sequence from WT to WTC and the client was storing it. The
client would later return the sequence. However, we never registered the
sequence as a dependency so it was one big no-op.

Remove all of the no-op code. Drop OnWindowSurfacedDetached() since it's
not needed now. Something along these lines will need to be added in the
future, but it will need to be synchronized with SubmitCompositorFrame()
so would need to be in a different interface anyways.

BUG=659227
==========

[commit-bot: I haz the power, 2016-11-09 03:17:49]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-11-09 03:22:26]

Description was changed from

==========
Remove SurfaceSequence from mus client code.

This is a first step in replacing all SurfaceSequences in mus. We were
passing a sequence from WT to WTC and the client was storing it. The
client would later return the sequence. However, we never registered the
sequence as a dependency so it was one big no-op.

Remove all of the no-op code. Drop OnWindowSurfacedDetached() since it's
not needed now. Something along these lines will need to be added in the
future, but it will need to be synchronized with SubmitCompositorFrame()
so would need to be in a different interface anyways.

BUG=659227
==========

to

==========
Remove SurfaceSequence from mus client code.

This is a first step in replacing all SurfaceSequences in mus. We were
passing a sequence from WT to WTC and the client was storing it. The
client would later return the sequence. However, we never registered the
sequence as a dependency so it was one big no-op.

Remove all of the no-op code. Drop OnWindowSurfacedDetached() since it's
not needed now. Something along these lines will need to be added in the
future, but it will need to be synchronized with SubmitCompositorFrame()
so would need to be in a different interface anyways.

BUG=659227

Committed: https://crrev.com/8f4cf6a6f7c47173fe85f7f6022bd5f64b84eb04
Cr-Commit-Position: refs/heads/master@{#430841}
==========

[commit-bot: I haz the power, 2016-11-09 03:22:28]

Patchset 5 (id:??) landed as
https://crrev.com/8f4cf6a6f7c47173fe85f7f6022bd5f64b84eb04
Cr-Commit-Position: refs/heads/master@{#430841}