Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2478373002: [MD History] Fix deletion in heavily scrolled list. (Closed)

Created:
4 years, 1 month ago by Dan Beam
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[MD History] Fix deletion in heavily scrolled list. This CL fixes an issue where results would reload when an item was deleted in a history list that was scrolled beyond the first 'page'. This was happening because code that refreshed the results on external deletion was getting triggered for internal deletes due to the web history service. This has been fixed by disabling the reload when web history deletions are occurring, bringing it in line with the local history service. BUG=660267, 630164 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2455503004 Cr-Commit-Position: refs/heads/master@{#429529} (cherry picked from commit a1ee6c76c90bfbe3cd842ac6d68cca5a6364738d) Committed: https://chromium.googlesource.com/chromium/src/+/eaf4e86ec35b1cb58dadc5dd0eff99f258412ce5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M chrome/browser/ui/webui/browsing_history_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/browsing_history_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/browsing_history_handler_unittest.cc View 2 chunks +20 lines, -1 line 0 comments Download
M components/history/core/browser/web_history_service.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Dan Beam
4 years, 1 month ago (2016-11-04 19:13:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eaf4e86ec35b1cb58dadc5dd0eff99f258412ce5.

Powered by Google App Engine
This is Rietveld 408576698