Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: components/history/core/browser/web_history_service.cc

Issue 2478373002: [MD History] Fix deletion in heavily scrolled list. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/browsing_history_handler_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/history/core/browser/web_history_service.cc
diff --git a/components/history/core/browser/web_history_service.cc b/components/history/core/browser/web_history_service.cc
index 35d97b85957559f9ce58aefca4d678ebdef09449..d66a39c313cee3bd02fdaedcdab804315d94fd23 100644
--- a/components/history/core/browser/web_history_service.cc
+++ b/components/history/core/browser/web_history_service.cc
@@ -563,13 +563,14 @@ void WebHistoryService::ExpireHistoryCompletionCallback(
if (response_value)
response_value->GetString("version_info", &server_version_info_);
}
- callback.Run(response_value.get() && success);
// Inform the observers about the history deletion.
if (response_value.get() && success) {
FOR_EACH_OBSERVER(WebHistoryServiceObserver, observer_list_,
OnWebHistoryDeleted());
}
+
+ callback.Run(response_value.get() && success);
}
void WebHistoryService::AudioHistoryCompletionCallback(
« no previous file with comments | « chrome/browser/ui/webui/browsing_history_handler_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698