HalfFloat neon armv7 fix for destination pointer.

HalfFloat neon armv7 fix for destination pointer.

Improved unittests detect different in arm64 rounding.

TEST=util/android/test_runner.py gtest -s libyuv_unittest -t 7200 --verbose --release --gtest_filter=*Half* -a "--libyuv_width=640 --libyuv_height=360"
BUG=libyuv:560
R=wangcheng@google.com

Committed: https://chromium.googlesource.com/libyuv/libyuv/+/f2c27dafa2950510ba767cd59937ddf5d1974937

[fbarchard1, 2016-11-04 21:52:54]

fbarchard@google.com changed reviewers:
+ wangcheng@google.com

[fbarchard1, 2016-11-04 21:52:54]

fix for ARMv7 HalfFloatPlane
allow off by 1 on denormal test.

[fbarchard1, 2016-11-04 22:22:13]

For the off by 1 the test just allows off by 1 for now, but it doesnt make sense
they would be different:

 [ RUN      ] LibYUVPlanarTest.TestHalfFloatPlane_16bit_denormal
 ../../unit_test/planar_test.cc:2142: Failure
 Expected: (diff) <= (0), actual: 1 vs 0
 [  FAILED  ] LibYUVPlanarTest.TestHalfFloatPlane_16bit_denormal (1 ms)
 [----------] 1 test from LibYUVPlanarTest (1 ms total)
 


The NEON code disassembles to this:

00000000 <HalfFloatRow_NEON>:
   0:	ee07 2a10 	vmov	s14, r2
   4:	eddf 7a0f 	vldr	s15, [pc, #60]	; 44 <HalfFloatRow_NEON+0x44>
   8:	ee67 7a27 	vmul.f32	s15, s14, s15
   c:	ee17 2a90 	vmov	r2, s15
  10:	eea0 2b10 	vdup.32	q0, r2
  14:	f920 2a0d 	vld1.8	{d2-d3}, [r0]!
  18:	3b08      	subs	r3, #8
  1a:	ff88 4a12 	vmovl.u8	q2, d2
  1e:	ff88 6a13 	vmovl.u8	q3, d3
  22:	ffbb 46c4 	vcvt.f32.u32	q2, q2
  26:	ffbb 66c6 	vcvt.f32.u32	q3, q3
  2a:	ff04 4d50 	vmul.f32	q2, q2, q0
  2e:	ff06 6d50 	vmul.f32	q3, q3, q0
  32:	ff93 2914 	vqshrn.u32	d2, q2, #13
  36:	ff93 3916 	vqshrn.u32	d3, q3, #13
  3a:	f901 2a0d 	vst1.8	{d2-d3}, [r1]!
  3e:	dce9      	bgt.n	14 <HalfFloatRow_NEON+0x14>
  40:	4770      	bx	lr
  42:	bf00      	nop
  44:	07800000 	.word	0x07800000

and the C code is
00000000 <HalfFloatRow_C>:
   0:	ed9f 7a0d 	vldr	s14, [pc, #52]	; 38 <HalfFloatRow_C+0x38>
   4:	ee07 2a90 	vmov	s15, r2
   8:	2b00      	cmp	r3, #0
   a:	ee27 7a87 	vmul.f32	s14, s15, s14
   e:	dd12      	ble.n	36 <HalfFloatRow_C+0x36>
  10:	3902      	subs	r1, #2
  12:	eb00 0343 	add.w	r3, r0, r3, lsl #1
  16:	f830 2b02 	ldrh.w	r2, [r0], #2
  1a:	ee07 2a90 	vmov	s15, r2
  1e:	eef8 7ae7 	vcvt.f32.s32	s15, s15
  22:	ee67 7a87 	vmul.f32	s15, s15, s14
  26:	ee17 2a90 	vmov	r2, s15
  2a:	4298      	cmp	r0, r3
  2c:	ea4f 3252 	mov.w	r2, r2, lsr #13
  30:	f821 2f02 	strh.w	r2, [r1, #2]!
  34:	d1ef      	bne.n	16 <HalfFloatRow_C+0x16>
  36:	4770      	bx	lr
  38:	07800000 	.word	0x07800000

[fbarchard1, 2016-11-04 22:22:48]

Description was changed from

==========
HalfFloat neon armv7 fix for destination pointer.

TEST=LibYUVPlanarTest.TestHalfFloatPlane_16bit_denormal
BUG=libyuv:560
==========

to

==========
HalfFloat neon armv7 fix for destination pointer.

TEST=LibYUVPlanarTest.TestHalfFloatPlane_16bit_denormal
BUG=libyuv:560
==========

[fbarchard1, 2016-11-04 22:22:49]

fbarchard@google.com changed reviewers:
+ mthiffault@google.com

[fbarchard1, 2016-11-04 22:23:11]

Fix in row_neon.cc for storing to correct location.

[fbarchard1, 2016-11-04 23:14:11]

[ RUN      ] LibYUVPlanarTest.TestHalfFloatPlane_16bit_denormal
 [       OK ] LibYUVPlanarTest.TestHalfFloatPlane_16bit_denormal (1 ms)
 [ RUN      ] LibYUVPlanarTest.TestHalfFloatPlane_16bit_One
 [       OK ] LibYUVPlanarTest.TestHalfFloatPlane_16bit_One (0 ms)
 [ RUN      ] LibYUVPlanarTest.TestHalfFloatPlane_16bit_Opt
 [       OK ] LibYUVPlanarTest.TestHalfFloatPlane_16bit_Opt (0 ms)
 [ RUN      ] LibYUVPlanarTest.TestHalfFloatPlane_10bit_Opt
 [       OK ] LibYUVPlanarTest.TestHalfFloatPlane_10bit_Opt (0 ms)
 [ RUN      ] LibYUVPlanarTest.TestHalfFloatPlane_9bit_Opt
 [       OK ] LibYUVPlanarTest.TestHalfFloatPlane_9bit_Opt (1 ms)
 [ RUN      ] LibYUVPlanarTest.TestHalfFloatPlane_Opt
 [       OK ] LibYUVPlanarTest.TestHalfFloatPlane_Opt (0 ms)
 [ RUN      ] LibYUVPlanarTest.TestHalfFloatPlane_One
 [       OK ] LibYUVPlanarTest.TestHalfFloatPlane_One (0 ms)
 [ RUN      ] LibYUVPlanarTest.TestHalfFloatPlane_Offby1
 [       OK ] LibYUVPlanarTest.TestHalfFloatPlane_Offby1 (0 ms)
 [----------] 8 tests from LibYUVPlanarTest (2 ms total)

[wangcheng, 2016-11-05 00:25:02]

https://codereview.chromium.org/2478313004/diff/50001/unit_test/planar_test.cc
File unit_test/planar_test.cc (right):

https://codereview.chromium.org/2478313004/diff/50001/unit_test/planar_test.c...
unit_test/planar_test.cc:2150: // 32 bit arm rounding on denormal is case is off
by 1 compared to C.
remove "is" in the comment

[fbarchard1, 2016-11-07 17:43:51]

https://codereview.chromium.org/2478313004/diff/50001/unit_test/planar_test.cc
File unit_test/planar_test.cc (right):

https://codereview.chromium.org/2478313004/diff/50001/unit_test/planar_test.c...
unit_test/planar_test.cc:2150: // 32 bit arm rounding on denormal is case is off
by 1 compared to C.
On 2016/11/05 00:25:02, wangcheng wrote:
> remove "is" in the comment

Done.

[fbarchard1, 2016-11-07 18:11:53]

arm64
TestHalfFloatPlane_16bit_denormal (900 ms)
TestHalfFloatPlane_16bit_One (806 ms)
TestHalfFloatPlane_16bit_Opt (1040 ms)
TestHalfFloatPlane_10bit_Opt (966 ms)
TestHalfFloatPlane_9bit_Opt (936 ms)
TestHalfFloatPlane_Opt (932 ms)
TestHalfFloatPlane_One (849 ms)
TestHalfFloatPlane_Offby1 (1013 ms)

armv7
TestHalfFloatPlane_16bit_denormal (1088 ms)
TestHalfFloatPlane_16bit_One (994 ms)
TestHalfFloatPlane_16bit_Opt (1032 ms)
TestHalfFloatPlane_10bit_Opt (996 ms)
TestHalfFloatPlane_9bit_Opt (924 ms)
TestHalfFloatPlane_Opt (939 ms)
TestHalfFloatPlane_One (1015 ms)
TestHalfFloatPlane_Offby1 (1026 ms)

[wangcheng, 2016-11-07 19:19:33]

lgtm

[fbarchard1, 2016-11-07 19:27:44]

Description was changed from

==========
HalfFloat neon armv7 fix for destination pointer.

TEST=LibYUVPlanarTest.TestHalfFloatPlane_16bit_denormal
BUG=libyuv:560
==========

to

==========
HalfFloat neon armv7 fix for destination pointer.

Improved unittests detect different in arm64 rounding.

TEST=util/android/test_runner.py gtest -s libyuv_unittest -t 7200 --verbose
--release --gtest_filter=*Half* -a "--libyuv_width=640 --libyuv_height=360"
BUG=libyuv:560
==========

[fbarchard1, 2016-11-07 20:13:06]

Description was changed from

==========
HalfFloat neon armv7 fix for destination pointer.

Improved unittests detect different in arm64 rounding.

TEST=util/android/test_runner.py gtest -s libyuv_unittest -t 7200 --verbose
--release --gtest_filter=*Half* -a "--libyuv_width=640 --libyuv_height=360"
BUG=libyuv:560
==========

to

==========
HalfFloat neon armv7 fix for destination pointer.

Improved unittests detect different in arm64 rounding.

TEST=util/android/test_runner.py gtest -s libyuv_unittest -t 7200 --verbose
--release --gtest_filter=*Half* -a "--libyuv_width=640 --libyuv_height=360"
BUG=libyuv:560
R=wangcheng@google.com

Committed:
https://chromium.googlesource.com/libyuv/libyuv/+/f2c27dafa2950510ba767cd5993...
==========

[fbarchard1, 2016-11-07 20:13:07]

Committed patchset #10 (id:170001) manually as
f2c27dafa2950510ba767cd59937ddf5d1974937 (presubmit successful).