Issue 2478313003: Fixed composed & detail fields in PointerEvents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2478313003: Fixed composed & detail fields in PointerEvents. (Closed)

Created:
4 years, 1 month ago by mustaq

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

Fixed composed & detail fields in PointerEvents. This fixes the bug that event paths for PointerEvents was ending at the shadow root. Also refactored PointerEventFactory, fixed an old test for mouse buttons. BUG=644398, 548226 Review-Url: https://codereview.chromium.org/2467983002 Cr-Commit-Position: refs/heads/master@{#429596} (cherry picked from commit 80926f9622b2c2f7e2d12e128372769ceedd883b) Committed: https://chromium.googlesource.com/chromium/src/+/538f85ad1261f957bd9c17b7b52d5c75c45a3afc

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -80 lines)			Patch
M	third_party/WebKit/LayoutTests/TestExpectations	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html	View	2 chunks	+11 lines, -6 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties-expected.txt	View	27 chunks	+55 lines, -63 lines	0 comments	Download
M	third_party/WebKit/Source/core/events/PointerEventFactory.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/events/PointerEventFactory.cpp	View	7 chunks	+9 lines, -10 lines	0 comments	Download

Total messages: 2 (1 generated)

mustaq

4 years, 1 month ago (2016-11-04 19:04:18 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
538f85ad1261f957bd9c17b7b52d5c75c45a3afc.