Fixed composed & detail fields in PointerEvents.

Fixed composed & detail fields in PointerEvents.

This fixes the bug that event paths for PointerEvents was ending at the
shadow root.

Also refactored PointerEventFactory, fixed an old test for mouse buttons.

BUG=644398, 548226
Committed: https://crrev.com/80926f9622b2c2f7e2d12e128372769ceedd883b
Cr-Commit-Position: refs/heads/master@{#429596}

[mustaq, 2016-11-01 19:57:41]

Description was changed from

==========
Fixed composed & detail fields in PointerEvents.

This fixes the bug that event paths for PointerEvents was ending at the
shadow root.

BUG=644398
==========

to

==========
Fixed composed & detail fields in PointerEvents.

This fixes the bug that event paths for PointerEvents was ending at the
shadow root.

Also refactored PointerEventFactory, fixed an old test for mouse buttons.

BUG=644398
==========

[mustaq, 2016-11-01 19:58:36]

Description was changed from

==========
Fixed composed & detail fields in PointerEvents.

This fixes the bug that event paths for PointerEvents was ending at the
shadow root.

Also refactored PointerEventFactory, fixed an old test for mouse buttons.

BUG=644398
==========

to

==========
Fixed composed & detail fields in PointerEvents.

This fixes the bug that event paths for PointerEvents was ending at the
shadow root.

Also refactored PointerEventFactory, fixed an old test for mouse buttons.

BUG=644398,548226
==========

[mustaq, 2016-11-01 19:59:11]

mustaq@chromium.org changed reviewers:
+ dtapuska@chromium.org

[mustaq, 2016-11-01 19:59:12]

ptal

[dtapuska, 2016-11-01 20:07:09]

On 2016/11/01 19:59:12, mustaq wrote:
> ptal

lgtm

[mustaq, 2016-11-03 13:42:24]

mustaq@chromium.org changed reviewers:
+ bokan@chromium.org

[mustaq, 2016-11-03 13:42:25]

bokan@chromium.org: Please review changes in Source/core

[bokan, 2016-11-03 13:51:24]

lgtm

https://codereview.chromium.org/2467983002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html
(right):

https://codereview.chromium.org/2467983002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html:164:
for (var button = 0; button <=2; button+=2) {
This is awkward, I'd just do:

eventSender.mouseDown(0)
eventSender.mouseUp(0)
eventSender.mouseDown(2)
eventSender.mouseUp(2)

[mustaq, 2016-11-03 13:59:46]

Patchset #3 (id:40001) has been deleted

[mustaq, 2016-11-03 14:01:09]

The CQ bit was checked by mustaq@chromium.org

[mustaq, 2016-11-03 14:01:10]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org,
dtapuska@chromium.org
Link to the patchset: https://codereview.chromium.org/2467983002/#ps60001
(title: "Added a comment on skipped mid-button test.")

[commit-bot: I haz the power, 2016-11-03 14:01:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mustaq, 2016-11-03 14:17:17]

https://codereview.chromium.org/2467983002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html
(right):

https://codereview.chromium.org/2467983002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html:164:
for (var button = 0; button <=2; button+=2) {
On 2016/11/03 13:51:24, bokan wrote:
> This is awkward, I'd just do:
> 
> eventSender.mouseDown(0)
> eventSender.mouseUp(0)
> eventSender.mouseDown(2)
> eventSender.mouseUp(2)

Done.

[commit-bot: I haz the power, 2016-11-03 15:35:15]

Description was changed from

==========
Fixed composed & detail fields in PointerEvents.

This fixes the bug that event paths for PointerEvents was ending at the
shadow root.

Also refactored PointerEventFactory, fixed an old test for mouse buttons.

BUG=644398,548226
==========

to

==========
Fixed composed & detail fields in PointerEvents.

This fixes the bug that event paths for PointerEvents was ending at the
shadow root.

Also refactored PointerEventFactory, fixed an old test for mouse buttons.

BUG=644398,548226
==========

[commit-bot: I haz the power, 2016-11-03 15:35:18]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-11-03 15:41:02]

Description was changed from

==========
Fixed composed & detail fields in PointerEvents.

This fixes the bug that event paths for PointerEvents was ending at the
shadow root.

Also refactored PointerEventFactory, fixed an old test for mouse buttons.

BUG=644398,548226
==========

to

==========
Fixed composed & detail fields in PointerEvents.

This fixes the bug that event paths for PointerEvents was ending at the
shadow root.

Also refactored PointerEventFactory, fixed an old test for mouse buttons.

BUG=644398,548226

Committed: https://crrev.com/80926f9622b2c2f7e2d12e128372769ceedd883b
Cr-Commit-Position: refs/heads/master@{#429596}
==========

[commit-bot: I haz the power, 2016-11-03 15:41:02]

Patchset 3 (id:??) landed as
https://crrev.com/80926f9622b2c2f7e2d12e128372769ceedd883b
Cr-Commit-Position: refs/heads/master@{#429596}