Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2478303002: Reland "Remove CPDF_Object::Release() in favor of direct delete" (Closed)

Created:
4 years, 1 month ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Reland "Remove CPDF_Object::Release() in favor of direct delete" This reverts commit f0d5b6c35fa343108a3ab7a25bc2cc2b3cf105b3. Committed: https://pdfium.googlesource.com/pdfium/+/33fdebc3da676bff84d0fd0f69b9087c0c12dfeb

Patch Set 1 : Original patch, unmodified. #

Patch Set 2 : Fix fuzzer build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -282 lines) Patch
M core/fpdfapi/edit/cpdf_creator.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/edit/fpdf_edit_create.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M core/fpdfapi/font/fpdf_font.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M core/fpdfapi/page/cpdf_contentmark.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M core/fpdfapi/page/cpdf_contentmarkitem.h View 1 chunk +2 lines, -4 lines 0 comments Download
M core/fpdfapi/page/cpdf_contentmarkitem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/page/cpdf_image.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/page/cpdf_image.cpp View 3 chunks +10 lines, -8 lines 0 comments Download
M core/fpdfapi/page/cpdf_streamcontentparser.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/page/cpdf_streamcontentparser.cpp View 9 chunks +19 lines, -24 lines 0 comments Download
M core/fpdfapi/page/fpdf_page_parser_old.cpp View 4 chunks +6 lines, -10 lines 0 comments Download
M core/fpdfapi/parser/cfdf_document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_array.h View 3 chunks +3 lines, -5 lines 0 comments Download
M core/fpdfapi/parser/cpdf_array.cpp View 3 chunks +5 lines, -8 lines 0 comments Download
M core/fpdfapi/parser/cpdf_array_unittest.cpp View 8 chunks +10 lines, -16 lines 0 comments Download
M core/fpdfapi/parser/cpdf_data_avail.cpp View 15 chunks +27 lines, -34 lines 0 comments Download
M core/fpdfapi/parser/cpdf_dictionary.h View 4 chunks +4 lines, -7 lines 0 comments Download
M core/fpdfapi/parser/cpdf_dictionary.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/parser/cpdf_document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_document_unittest.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_indirect_object_holder.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_indirect_object_holder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_object.h View 4 chunks +2 lines, -6 lines 0 comments Download
M core/fpdfapi/parser/cpdf_object.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M core/fpdfapi/parser/cpdf_object_unittest.cpp View 27 chunks +36 lines, -40 lines 0 comments Download
M core/fpdfapi/parser/cpdf_parser.cpp View 14 chunks +20 lines, -34 lines 0 comments Download
M core/fpdfapi/parser/cpdf_stream.h View 3 chunks +4 lines, -6 lines 0 comments Download
M core/fpdfapi/parser/cpdf_stream.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_string.h View 2 chunks +1 line, -2 lines 0 comments Download
M core/fpdfapi/parser/cpdf_syntax_parser.cpp View 7 chunks +7 lines, -10 lines 0 comments Download
M core/fpdfdoc/cpdf_annot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_filespec_unittest.cpp View 6 chunks +5 lines, -12 lines 0 comments Download
M core/fpdfdoc/cpdf_formfield.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M core/fxge/dib/fx_dib_engine_unittest.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M fpdfsdk/fpdfdoc_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfppo.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M testing/libfuzzer/pdf_codec_jbig2_fuzzer.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M testing/libfuzzer/pdf_hint_table_fuzzer.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download
M testing/libfuzzer/pdf_streamparser_fuzzer.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Tom Sepez
Lei, quick review of PS2 delta.
4 years, 1 month ago (2016-11-04 17:24:54 UTC) #4
Lei Zhang
lgtm
4 years, 1 month ago (2016-11-04 18:29:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478303002/20001
4 years, 1 month ago (2016-11-04 18:38:21 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 18:38:43 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/33fdebc3da676bff84d0fd0f69b9087c0c12...

Powered by Google App Engine
This is Rietveld 408576698