core/fpdfapi/parser/cpdf_object.cpp - Issue 2478303002: Reland "Remove CPDF_Object::Release() in favor of direct delete"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/parser/cpdf_object.cpp

Issue 2478303002: Reland "Remove CPDF_Object::Release() in favor of direct delete" (Closed)

Patch Set: Fix fuzzer build Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/parser/cpdf_object.cpp

diff --git a/core/fpdfapi/parser/cpdf_object.cpp b/core/fpdfapi/parser/cpdf_object.cpp

index cc410d10c8fdf125bc2525f31ea6dd2e5aafda77..e9c215ce19b68f62998c022656e57d611e4ab38d 100644

--- a/core/fpdfapi/parser/cpdf_object.cpp

+++ b/core/fpdfapi/parser/cpdf_object.cpp

@@ -37,11 +37,6 @@ CPDF_Object* CPDF_Object::CloneNonCyclic(

return Clone();

}

-void CPDF_Object::Release() {

- CHECK(!m_ObjNum);

- delete this;

CFX_ByteString CPDF_Object::GetString() const {

return CFX_ByteString();

}

« no previous file with comments | « core/fpdfapi/parser/cpdf_object.h ('k') | core/fpdfapi/parser/cpdf_object_unittest.cpp » ('j') | no next file with comments »