Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2478153003: Fix notification test to return a promise. (Closed)

Created:
4 years, 1 month ago by harkness
Modified:
4 years, 1 month ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, blink-reviews, Peter Beverloo, awdf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix notification test to return a promise. A recent change to testharness.js (https://codereview.chromium.org/2468053002) causes promise_test to throw a TypeError exception when the test returns something other than a promise. This CL fixes one notification test which was not explicitly returning the promise. BUG=662172 Committed: https://crrev.com/eeafa338d2075075df0760d14935c5c9f3102190 Cr-Commit-Position: refs/heads/master@{#429915}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-fetch-resources.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-fetch-resources-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
harkness
4 years, 1 month ago (2016-11-04 15:37:49 UTC) #2
Peter Beverloo
lgtm
4 years, 1 month ago (2016-11-04 15:42:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478153003/1
4 years, 1 month ago (2016-11-04 15:42:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 16:46:26 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 17:15:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eeafa338d2075075df0760d14935c5c9f3102190
Cr-Commit-Position: refs/heads/master@{#429915}

Powered by Google App Engine
This is Rietveld 408576698