Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2477993004:
Clean up some nits in ash/touch/touchscreen_util.cc. (Closed)
|
Created:
4 years, 1 month ago by Lei Zhang Modified:
4 years, 1 month ago Reviewers:
Daniel Erat CC:
chromium-reviews, kalyank, sadrul Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionClean up some nits in ash/touch/touchscreen_util.cc.
Committed: https://crrev.com/8a1a19af392e11f8e857dc3e5277ea98954de715
Cr-Commit-Position: refs/heads/master@{#430352}
Patch Set 1 #
Total comments: 2
Patch Set 2 : rebase, auto #Messages
Total messages: 18 (12 generated)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
thestig@chromium.org changed reviewers: + derat@chromium.org
lgtm https://codereview.chromium.org/2477993004/diff/1/ash/touch/touchscreen_util.cc File ash/touch/touchscreen_util.cc (right): https://codereview.chromium.org/2477993004/diff/1/ash/touch/touchscreen_util.... ash/touch/touchscreen_util.cc:33: for (const base::FilePath::StringType& component : components) { nit: auto?
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
https://codereview.chromium.org/2477993004/diff/1/ash/touch/touchscreen_util.cc File ash/touch/touchscreen_util.cc (right): https://codereview.chromium.org/2477993004/diff/1/ash/touch/touchscreen_util.... ash/touch/touchscreen_util.cc:33: for (const base::FilePath::StringType& component : components) { On 2016/11/07 19:08:12, Daniel Erat wrote: > nit: auto? Done. Not sure why it wasn't auto in the first place.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thestig@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org Link to the patchset: https://codereview.chromium.org/2477993004/#ps20001 (title: "rebase, auto")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Clean up some nits in ash/touch/touchscreen_util.cc. ========== to ========== Clean up some nits in ash/touch/touchscreen_util.cc. Committed: https://crrev.com/8a1a19af392e11f8e857dc3e5277ea98954de715 Cr-Commit-Position: refs/heads/master@{#430352} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8a1a19af392e11f8e857dc3e5277ea98954de715 Cr-Commit-Position: refs/heads/master@{#430352} |
