Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: net/spdy/hpack_decoder_test.cc

Issue 247793002: HPACK: Refactor and simplify HpackOutputStream (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/spdy/hpack_encoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/hpack_decoder_test.cc
diff --git a/net/spdy/hpack_decoder_test.cc b/net/spdy/hpack_decoder_test.cc
index e96dc1e6bcb7a186652e2f8bd8c115609aa21e2c..fa983fcd619bd32b50365477a1e6590063510121 100644
--- a/net/spdy/hpack_decoder_test.cc
+++ b/net/spdy/hpack_decoder_test.cc
@@ -252,10 +252,10 @@ TEST_F(HpackDecoderTest, ContextUpdateMaximumSize) {
string input;
{
// Maximum-size update with kDefaultHeaderTableSizeSetting. Succeeds.
- HpackOutputStream output_stream(kuint32max);
+ HpackOutputStream output_stream;
output_stream.AppendBits(0x80, 8); // Context update.
output_stream.AppendBits(0x00, 1); // Size update.
- output_stream.AppendUint32ForTest(kDefaultHeaderTableSizeSetting);
+ output_stream.AppendUint32(kDefaultHeaderTableSizeSetting);
output_stream.TakeString(&input);
EXPECT_TRUE(DecodeHeaderBlock(StringPiece(input)));
@@ -264,10 +264,10 @@ TEST_F(HpackDecoderTest, ContextUpdateMaximumSize) {
}
{
// Maximum-size update with kDefaultHeaderTableSizeSetting + 1. Fails.
- HpackOutputStream output_stream(kuint32max);
+ HpackOutputStream output_stream;
output_stream.AppendBits(0x80, 8); // Context update.
output_stream.AppendBits(0x00, 1); // Size update.
- output_stream.AppendUint32ForTest(kDefaultHeaderTableSizeSetting + 1);
+ output_stream.AppendUint32(kDefaultHeaderTableSizeSetting + 1);
output_stream.TakeString(&input);
EXPECT_FALSE(DecodeHeaderBlock(StringPiece(input)));
« no previous file with comments | « no previous file | net/spdy/hpack_encoder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698