Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: build/android/pylib/gtest/gtest_test_instance_test.py

Issue 2477813002: Fixing how --gtest-filter-file handles negative patterns. (Closed)
Patch Set: Converted a comment into a doc string. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/gtest/gtest_test_instance.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/gtest/gtest_test_instance_test.py
diff --git a/build/android/pylib/gtest/gtest_test_instance_test.py b/build/android/pylib/gtest/gtest_test_instance_test.py
index 02e29bb4600281ce6c28676ed7e4f494182fca6c..c7ad0744093c437178fde745d76ab44f845ead74 100755
--- a/build/android/pylib/gtest/gtest_test_instance_test.py
+++ b/build/android/pylib/gtest/gtest_test_instance_test.py
@@ -165,6 +165,51 @@ class GtestTestInstanceTests(unittest.TestCase):
self.assertEquals(1, actual[0].GetDuration())
self.assertEquals(base_test_result.ResultType.PASS, actual[0].GetType())
+ def testConvertTestFilterFile_commentsAndBlankLines(self):
+ input_lines = [
+ 'positive1',
+ '# comment',
+ 'positive2',
+ ''
+ 'positive3'
+ ]
+ actual = gtest_test_instance \
+ .ConvertTestFilterFileIntoGTestFilterArgument(input_lines)
+ expected = 'positive1:positive2:positive3'
+ self.assertEquals(expected, actual)
+
+ def testConvertTestFilterFile_onlyPositive(self):
+ input_lines = [
+ 'positive1',
+ 'positive2'
+ ]
+ actual = gtest_test_instance \
+ .ConvertTestFilterFileIntoGTestFilterArgument(input_lines)
+ expected = 'positive1:positive2'
+ self.assertEquals(expected, actual)
+
+ def testConvertTestFilterFile_onlyNegative(self):
+ input_lines = [
+ '-negative1',
+ '-negative2'
+ ]
+ actual = gtest_test_instance \
+ .ConvertTestFilterFileIntoGTestFilterArgument(input_lines)
+ expected = '-negative1:negative2'
+ self.assertEquals(expected, actual)
+
+ def testConvertTestFilterFile_positiveAndNegative(self):
+ input_lines = [
+ 'positive1',
+ 'positive2',
+ '-negative1',
+ '-negative2'
+ ]
+ actual = gtest_test_instance \
+ .ConvertTestFilterFileIntoGTestFilterArgument(input_lines)
+ expected = 'positive1:positive2-negative1:negative2'
+ self.assertEquals(expected, actual)
+
if __name__ == '__main__':
unittest.main(verbosity=2)
« no previous file with comments | « build/android/pylib/gtest/gtest_test_instance.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698