Fixing how --gtest-filter-file handles negative patterns.

build/android/pylib/gtest/gtest_test_instance_test.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import unittest
 
 from pylib.base import base_test_result
 from pylib.gtest import gtest_test_instance
 
@@ skipping 147 matching lines @@
       '[ CRASHED      ]',
       '[       OK ] FooTest.Bar (1 ms)',
     ]
     actual = gtest_test_instance.ParseGTestOutput(raw_output)
     self.assertEquals(1, len(actual))
 
     self.assertEquals('FooTest.Bar', actual[0].GetName())
     self.assertEquals(1, actual[0].GetDuration())
     self.assertEquals(base_test_result.ResultType.PASS, actual[0].GetType())
 
+  def testConvertTestFilterFile_commentsAndBlankLines(self):
+    input_lines = [
+      'positive1',
+      '# comment',
+      'positive2',
+      ''
+      'positive3'
+    ]
+    actual = gtest_test_instance \
+        .ConvertTestFilterFileIntoGTestFilterArgument(input_lines)
+    expected = 'positive1:positive2:positive3'
+    self.assertEquals(expected, actual)
+
+  def testConvertTestFilterFile_onlyPositive(self):
+    input_lines = [
+      'positive1',
+      'positive2'
+    ]
+    actual = gtest_test_instance \
+        .ConvertTestFilterFileIntoGTestFilterArgument(input_lines)
+    expected = 'positive1:positive2'
+    self.assertEquals(expected, actual)
+
+  def testConvertTestFilterFile_onlyNegative(self):
+    input_lines = [
+      '-negative1',
+      '-negative2'
+    ]
+    actual = gtest_test_instance \
+        .ConvertTestFilterFileIntoGTestFilterArgument(input_lines)
+    expected = '-negative1:negative2'
+    self.assertEquals(expected, actual)
+
+  def testConvertTestFilterFile_positiveAndNegative(self):
+    input_lines = [
+      'positive1',
+      'positive2',
+      '-negative1',
+      '-negative2'
+    ]
+    actual = gtest_test_instance \
+        .ConvertTestFilterFileIntoGTestFilterArgument(input_lines)
+    expected = 'positive1:positive2-negative1:negative2'
+    self.assertEquals(expected, actual)
+
 
 if __name__ == '__main__':
   unittest.main(verbosity=2)