Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issue 2477673006: Get the basics of deferred libraries working. (Closed)

Created:
2 years, 11 months ago by Bob Nystrom
Modified:
2 years, 11 months ago
Reviewers:
vsm, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Get the basics of deferred libraries working. References to loadLibrary on a library prefix are compiled to a helper function that returns a Future that always completes successfully. The deferred libraries aren't actually deferred, but code that uses loadLibrary() now doesn't barf. BUG=#27343 R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/8daf4cfb73aa92c035f360832ccc7218e41d79a1

Patch Set 1 #

Patch Set 2 : Update CHANGELOG. #

Patch Set 3 : Rebase against latest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -97 lines) Patch
M CHANGELOG.md View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 3 chunks +30 lines, -0 lines 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 1 chunk +5 lines, -12 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/dev_compiler/tool/sdk_expected_errors.txt View 1 2 2 chunks +10 lines, -85 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Bob Nystrom
2 years, 11 months ago (2016-11-05 00:38:07 UTC) #2
vsm
lgtm!
2 years, 11 months ago (2016-11-07 15:31:17 UTC) #3
Bob Nystrom
Committed patchset #3 (id:40001) manually as 8daf4cfb73aa92c035f360832ccc7218e41d79a1 (presubmit successful).
2 years, 11 months ago (2016-11-07 18:41:29 UTC) #5
Jennifer Messerly
2 years, 11 months ago (2016-11-07 20:15:00 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698