Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: pkg/dev_compiler/test/browser/language_tests.js

Issue 2477673006: Get the basics of deferred libraries working. (Closed)
Patch Set: Rebase against latest. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/test/browser/language_tests.js
diff --git a/pkg/dev_compiler/test/browser/language_tests.js b/pkg/dev_compiler/test/browser/language_tests.js
index 378ac92a5074f916e949fdd377b98bd450667e84..948d48a0e4bcbdc226163cbb7be8461c60607fcb 100644
--- a/pkg/dev_compiler/test/browser/language_tests.js
+++ b/pkg/dev_compiler/test/browser/language_tests.js
@@ -124,22 +124,15 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'cyclic_type_test_03_multi': skip_fail,
'cyclic_type_test_04_multi': skip_fail,
'cyclic_type_variable_test_none_multi': skip_fail,
+
+ // Deferred libraries are not actually deferred. These tests all test
+ // that synchronous access to the library fails.
'deferred_call_empty_before_load_test': skip_fail,
- 'deferred_closurize_load_library_test': skip_fail,
- 'deferred_constant_list_test': skip_fail,
- 'deferred_function_type_test': skip_fail,
- 'deferred_inlined_test': skip_fail,
- 'deferred_load_inval_code_test': skip_fail,
- 'deferred_mixin_test': skip_fail,
- 'deferred_no_such_method_test': skip_fail, // deferred libs not implemented
'deferred_not_loaded_check_test': skip_fail,
- 'deferred_only_constant_test': skip_fail,
- 'deferred_optimized_test': skip_fail,
'deferred_redirecting_factory_test': skip_fail,
- 'deferred_regression_22995_test': skip_fail,
- 'deferred_shadow_load_library_test': skip_fail,
- 'deferred_shared_and_unshared_classes_test': skip_fail,
'deferred_static_seperate_test': skip_fail,
+
+ 'deferred_regression_22995_test': skip_fail, // Strong mode "is" rejects some type tests.
'double_int_to_string_test': skip_fail,
'double_to_string_test': skip_fail,
'dynamic_test': skip_fail,

Powered by Google App Engine
This is Rietveld 408576698