fix conformance2/textures/misc/tex-image-with-bad-args.html

fix conformance2/textures/misc/tex-image-with-bad-args.html

BUG=656889
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/d74e48c456ec3334eaed3b45ca7bad5c7c681f24
Cr-Commit-Position: refs/heads/master@{#430428}

[Kai Ninomiya, 2016-11-04 23:24:00]

Description was changed from

==========
fix conformance2/textures/misc/tex-image-with-bad-args.html

BUG=656889
==========

to

==========
fix conformance2/textures/misc/tex-image-with-bad-args.html

BUG=656889
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-11-04 23:24:00]

Description was changed from

==========
fix conformance2/textures/misc/tex-image-with-bad-args.html

BUG=656889
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
fix conformance2/textures/misc/tex-image-with-bad-args.html

BUG=656889
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-11-04 23:24:53]

kainino@chromium.org changed reviewers:
+ zmo@chromium.org

[Kai Ninomiya, 2016-11-04 23:24:54]

zmo, PTAL

[Kai Ninomiya, 2016-11-04 23:25:14]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 23:26:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kai Ninomiya, 2016-11-04 23:46:49]

The CQ bit was unchecked by kainino@chromium.org

[Kai Ninomiya, 2016-11-05 19:59:59]

On 2016/11/04 23:24:54, Kai Ninomiya wrote:
> zmo, PTAL

Wrapping up my train of thought from yesterday.

The failing test is for CopyTexImage2D. I think the test
(GLES2DecoderManualInitTest.CopyTexImage2DUnsizedInternalFormatES3) is
wrong. Itseems to expect that unsized internal formats are allowed on ES3
for CopyTexImage2D. The spec says:

> 3.8.5 Alternate Texture Image Specification Commands
> 
> (...)
> 
> Parameters level, internalformat, and border are specified using the same
> values, with the same meanings, as the equivalent arguments of TexImage2D.

zmo, would you mind verifying this when you get a chance?

[Kai Ninomiya, 2016-11-07 22:28:05]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 22:28:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kai Ninomiya, 2016-11-07 23:35:02]

On 2016/11/05 19:59:59, Kai Ninomiya wrote:
> On 2016/11/04 23:24:54, Kai Ninomiya wrote:
> > zmo, PTAL
> 
> Wrapping up my train of thought from yesterday.
> 
> The failing test is for CopyTexImage2D. I think the test
> (GLES2DecoderManualInitTest.CopyTexImage2DUnsizedInternalFormatES3) is
> wrong. Itseems to expect that unsized internal formats are allowed on ES3
> for CopyTexImage2D. The spec says:
> 
> > 3.8.5 Alternate Texture Image Specification Commands
> > 
> > (...)
> > 
> > Parameters level, internalformat, and border are specified using the same
> > values, with the same meanings, as the equivalent arguments of TexImage2D.
> 
> zmo, would you mind verifying this when you get a chance?

FTR: Discussed this offline.

zmo: PTAL, this is actually ready for review this time.

[commit-bot: I haz the power, 2016-11-07 23:44:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 23:44:17]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2016-11-07 23:47:06]

On 2016/11/07 23:35:02, Kai Ninomiya wrote:
> On 2016/11/05 19:59:59, Kai Ninomiya wrote:
> > On 2016/11/04 23:24:54, Kai Ninomiya wrote:
> > > zmo, PTAL
> > 
> > Wrapping up my train of thought from yesterday.
> > 
> > The failing test is for CopyTexImage2D. I think the test
> > (GLES2DecoderManualInitTest.CopyTexImage2DUnsizedInternalFormatES3) is
> > wrong. Itseems to expect that unsized internal formats are allowed on ES3
> > for CopyTexImage2D. The spec says:
> > 
> > > 3.8.5 Alternate Texture Image Specification Commands
> > > 
> > > (...)
> > > 
> > > Parameters level, internalformat, and border are specified using the same
> > > values, with the same meanings, as the equivalent arguments of TexImage2D.
> > 
> > zmo, would you mind verifying this when you get a chance?
> 
> FTR: Discussed this offline.
> 
> zmo: PTAL, this is actually ready for review this time.

lgtm

[Kai Ninomiya, 2016-11-07 23:47:25]

The CQ bit was checked by kainino@chromium.org

[commit-bot: I haz the power, 2016-11-07 23:48:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 23:57:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-08 00:10:10]

Description was changed from

==========
fix conformance2/textures/misc/tex-image-with-bad-args.html

BUG=656889
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
fix conformance2/textures/misc/tex-image-with-bad-args.html

BUG=656889
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/d74e48c456ec3334eaed3b45ca7bad5c7c681f24
Cr-Commit-Position: refs/heads/master@{#430428}
==========

[commit-bot: I haz the power, 2016-11-08 00:10:11]

Patchset 2 (id:??) landed as
https://crrev.com/d74e48c456ec3334eaed3b45ca7bad5c7c681f24
Cr-Commit-Position: refs/heads/master@{#430428}